Address folder and package mismatch in completion tests #4250
+20
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datho7561
added a commit
to datho7561/eclipse.jdt.core
that referenced
this pull request
Aug 28, 2025
See eclipse-jdt#4250 Some test classes have different folder and package names. `javac` uses the package name stated in the class if there's a mismatch, and ECJ uses the folder name. However, these tests aren't testing for that behaviour; the package mismatch seems to have been an oversight of the person coding the tests. As a result, I think it's best to make the package and folder line up properly. Signed-off-by: David Thompson <[email protected]>
3 tasks
Some completion tests use test files that have mismatching package declarations and folder locations. These tests aren't testing for how mismatching the package declaration and folder location affects the completion results, so I think itwould be helpful to make the declared package and folder match. Signed-off-by: David Thompson <[email protected]>
datho7561
force-pushed
the
test-package-and-folder-mismatch
branch
from
dcb2e53 to
0062f30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Some completion tests use test files that have mismatching package declarations and folder locations.
These tests aren't testing for how mismatching the package declaration and folder location affects the completion results, so I think it would be helpful to make the declared package and folder match.
How to test
I've updated the existing test cases.
Author checklist