GLSP-1586: Refactor MenuItem API #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tortmayr
added a commit
to eclipse-glsp/glsp-theia-integration
that referenced
this pull request
Oct 7, 2025
Adjust Theia GLSP context menu service for new MenuItem API. Ensure that isEnabled,isVisible and isToggled are properly forwarded to the Theia Menu item Part of eclipse-glsp/glsp#1586 Requires: eclipse-glsp/glsp-client#450 Requires: eclipse-glsp/glsp-server-node#116
2 tasks
tortmayr
added a commit
to eclipse-glsp/glsp-server
that referenced
this pull request
Oct 7, 2025
Counterpart to eclipse-glsp/glsp-server-node#116 Part of eclipse-glsp/glsp#1586
2 tasks
- Adjust context menu item provider to new `ServerMenuItem` API - Extend workflow context menu provider - Add a hidden item for testing - Add a `Readonly` mode toggle entry Part of eclipse-glsp/glsp#1586 GLSP-1587: - Add missing action handler for `SetEditModeAction` - Align base `CommandPaletteActionProvider` with java-server implementation (do not return empty for readonly by default) Fixes eclipse-glsp/glsp#1587 Requires eclipse-glsp/glsp-client#450
tortmayr
added a commit
to eclipse-glsp/glsp-theia-integration
that referenced
this pull request
Oct 10, 2025
* GLSP-1586: Adjust to new MenuItem API Adjust Theia GLSP context menu service for new MenuItem API. Ensure that isEnabled,isVisible and isToggled are properly forwarded to the Theia Menu item Part of eclipse-glsp/glsp#1586 Requires: eclipse-glsp/glsp-client#450 Requires: eclipse-glsp/glsp-server-node#116 * Upgrade yarn lock
tortmayr
added a commit
to eclipse-glsp/glsp-server
that referenced
this pull request
Oct 20, 2025
* GLSP-1586: Adjust to new MenuItem API Counterpart to eclipse-glsp/glsp-server-node#116 Part of eclipse-glsp/glsp#1586 * Address review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
ServerMenuItemAPIReadonlymode toggle entryPart of eclipse-glsp/glsp#1586
GLSP-1587:
SetEditModeActionCommandPaletteActionProviderwith java-server implementation (do not return empty for readonly by default)Fixes eclipse-glsp/glsp#1587
Requires eclipse-glsp/glsp-client#450
How to test
Follow-ups
Changelog