Add Arrow Up/Down and Page Up/Down support for table-output-component #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for using the Arrow Up/Down and Page Up/Down to navigate across pages for views that implements the table-output-component. Previously, user can only use these keys to navigate across a page, but can not move forward or backward a page. Fixes eclipse-cdt-cloud#848. Signed-off-by: Hoang Thuan Pham <[email protected]>
|
Marked as draft due to the following issue: UI/UX wise, when user switch pages, we should focus on the cell that is 1) in the same column as previously selected and 2) on the first and last row when we are going forward and backward a page, respectively. I still cannot get this working. I tried using gridAPI.setFocusedCell() but it failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for using the Arrow Up/Down and Page Up/Down to navigate across pages for views that implements the table-output-component. Previously, user can only use these keys to navigate across a page, but can not move forward or backward a page.
Fixes #848.
Signed-off-by: Hoang Thuan Pham [email protected]