Skip to content

Conversation

@aaanh
Copy link
Contributor

@aaanh aaanh commented Aug 12, 2025

What it does

Add range selection sync feature, similar to Flame graph selection, to the extension. Along with a sync toggle button for the Gantt chart.

flame.graph.selection.mp4

Along with this PR, refactored the UnitController class's numberTranslator to use a new utility factory method createNumberTranslator.

How to test

  • Check out this PR.
  • Open an lttng-ust trace (e.g. fibonacci or cyg-profile)
  • Open both flame chart and flame graph views
  • Left-mouse drag over the flame chart to select a range for analysis
  • Turn on the sync with the toggle button on Flame graph view
  • Expect to see the Flame graph is properly rendering agrregated states within the (global) time range selection
  • Turn off to see the Flame graph is restored to show all states in experiment

Follow-ups

N/A

Review checklist

  • As an author, I have thoroughly tested my changes and carefully followed the instructions in this template

@aaanh aaanh force-pushed the aaanh/gantt/select-range branch 3 times, most recently from 0f5bfbd to 106959e Compare August 12, 2025 19:40
@aaanh aaanh changed the title Gantt: Add global range selection sync to Gantt chart with toggle button Add global range selection sync to Gantt chart with toggle button Aug 12, 2025
@marcdumais-work
Copy link
Contributor

I think the license check CI failure is unrelated to the content of the PR and can be ignored for now.

@aaanh aaanh force-pushed the aaanh/gantt/select-range branch from 106959e to 9388306 Compare August 12, 2025 20:29
@aaanh aaanh force-pushed the aaanh/gantt/select-range branch 6 times, most recently from ae433fe to 71563ac Compare August 22, 2025 15:24
@aaanh
Copy link
Contributor Author

aaanh commented Aug 22, 2025

Latest changes to the PR:

  • Rename responseType variable to providerType to stay consistent with the naming scheme
  • Fix x-axis sync issues
  • Fix incorrect offset when selecting a global range in sync mode

@aaanh aaanh force-pushed the aaanh/gantt/select-range branch from 71563ac to 4f9cf0e Compare September 11, 2025 18:56
@aaanh aaanh marked this pull request as draft September 15, 2025 21:57
@aaanh aaanh force-pushed the aaanh/gantt/select-range branch from 8b736c2 to ab28cc6 Compare September 25, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants