-
Notifications
You must be signed in to change notification settings - Fork 214
test if all extensions support parallel install before attempting parallel extension install #4949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tall raises `NotImplementedError`
Instead of this workaround/hack, I think we can implement a more direct lightweight check to see if all extensions support installing in parallel. It should basically boil down to checking whether the Then it's a simply |
ext.toolchain.prepare
twice if the parallel extension install raises NotImplementedError
Done |
Co-authored-by: Kenneth Hoste <[email protected]>
…nstalled in parallel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
testing with matplotlib
(doesn't support installing in parallel) + R
and R-bundle-*
on top, just to make sure...
fixes #4897, closes #4948