Skip to content

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Jul 3, 2025

fixes #4897, closes #4948

@branfosj branfosj added this to the release after 5.1.1 milestone Jul 4, 2025
@boegel
Copy link
Member

boegel commented Jul 30, 2025

Instead of this workaround/hack, I think we can implement a more direct lightweight check to see if all extensions support installing in parallel.

It should basically boil down to checking whether the install_extension_async method that will be used is the default Extension.install_extension_async method (which will raise NotImplementedError) or whether it's a customized version of it (which in practice should mean that the extension supports parallel installation).

Then it's a simply if/else rather than a try/except, and there's no room for calling the prepare method twice...

@branfosj branfosj changed the title do not do ext.toolchain.prepare twice if the parallel extension install raises NotImplementedError test if all extensions support parallel install before attempting parallel extension install Jul 31, 2025
@branfosj
Copy link
Member Author

Instead of this workaround/hack, I think we can implement a more direct lightweight check to see if all extensions support installing in parallel.

It should basically boil down to checking whether the install_extension_async method that will be used is the default Extension.install_extension_async method (which will raise NotImplementedError) or whether it's a customized version of it (which in practice should mean that the extension supports parallel installation).

Then it's a simply if/else rather than a try/except, and there's no room for calling the prepare method twice...

Done

Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

testing with matplotlib (doesn't support installing in parallel) + R and R-bundle-* on top, just to make sure...

@boegel boegel merged commit 421e6a3 into easybuilders:develop Aug 13, 2025
37 checks passed
@branfosj branfosj deleted the parallel_ext branch August 13, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

2 participants