change copy_file function to raise an error when trying to copy non-existing file #3836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 15, 2021 08:57
Previous behavior would simply skip copying a file if it did not exist and report copy success. This commit changes that behavior to error out early if the file does not exist and explicitly warn if trying to copy something that is neither a file nor a symbolic link.
Previous intention is simply to let the error bubble up if the copy tries to affect a directory.
boegel
requested changes
Sep 15, 2021
boegel
changed the title
|
@nordmoen Are you up for extending the |
boegel
changed the title
Should be able to, yes |
boegel
changed the title
boegel
requested changes
Sep 17, 2021
…ybuild-framework into ensure_path_exist_copy_file
boegel
approved these changes
Sep 17, 2021
boegel
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior would simply skip copying a file if it did not exist
and report copy success. This commit changes that behavior to error out
early if the file does not exist and explicitly warn if trying to copy
something that is neither a file nor a symbolic link.