Skip to content

expand progress bar to full screen width #3826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 12, 2021
Merged

expand progress bar to full screen width #3826

merged 3 commits into from
Sep 12, 2021

Conversation

@branfosj
Copy link
Member

@branfosj branfosj commented Sep 12, 2021 •
edited
Loading

(created using eb --new-pr)

The expand=True makes the progress line take the full width and setting bar_width=None on the BarColumn expands the progress bar to use all available space.

@branfosj branfosj added this to the 4.x milestone Sep 12, 2021
@branfosj branfosj mentioned this pull request Sep 12, 2021
Open
This was referenced Sep 12, 2021
Closed
Merged
@boegel boegel added the change label Sep 12, 2021
@boegel boegel modified the milestones: 4.x, next release (4.4.3?) Sep 12, 2021
boegel
boegel approved these changes Sep 12, 2021
View reviewed changes
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel boegel merged commit 6158455 into easybuilders:develop Sep 12, 2021
@branfosj branfosj deleted the 20210912083227_new_pr_WpboXfBqPF branch September 12, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

change enhancement

Projects

None yet

Milestone

4.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@branfosj @boegel