prepend location for temporary module file to $MODULEPATH with high priority + mark it as default in load_fake_module method #2506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s released >3 years ago) + make flake8 happy
…riority in load_fake_module method
wpoely86
reviewed
May 22, 2018
easybuild/tools/modules.py
Outdated
| :param priority: priority for this path in $MODULEPATH (Lmod-specific) | ||
| """ | ||
| if priority: | ||
| self.log.info("Ignoring specified priority '%s' when prepending %s to $MODULEPATH", priority, path) |
There was a problem hiding this comment.
I would add something here that it's called in use, not a prepend_path?
| mkdir(path, parents=True) | ||
|
|
||
| if priority: | ||
| self.run_module(['use', '--priority', str(priority), path]) |
There was a problem hiding this comment.
I thought it was Lmod specific?
There was a problem hiding this comment.
It is, this use implementation is custom to the Lmod class.
easybuild/tools/modules.py
Outdated
| :param priority: priority for this path in $MODULEPATH (Lmod-specific) | ||
| """ | ||
| if priority: | ||
| self.log.info("Ignoring specified priority '%s' when running 'module use %s'", priority, path) |
There was a problem hiding this comment.
while in the code it's clear, I wonder if the log messages should also mention why the priority is ignored, for those not using Lmod
…her existing module file that is set as default
boegel
changed the title
wpoely86
approved these changes
May 23, 2018
This was referenced Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #2499 reported by @mboisson based on suggestion by @ocaisa