Skip to content

Conversation

@boegel
Copy link
Member

@boegel boegel commented Apr 21, 2018

singularity --version always need to be run, to avoid this crash:

Traceback (most recent call last):
  File "/example/easybuild-framework/test/framework/containers.py", line 260, in test_end2end_singularity_image
    stdout, stderr = self.run_main(args)
  File "/example/easybuild-framework/test/framework/containers.py", line 84, in run_main
    self.eb_main(args, raise_error=True, verbose=True, do_build=True)
  File "/example/easybuild-framework/test/framework/utilities.py", line 295, in eb_main
    raise myerr
AttributeError: LooseVersion instance has no attribute 'version'

cc @shahzebsiddiqui

@boegel boegel added the bug fix label Apr 21, 2018
@boegel boegel added this to the 3.6.0 milestone Apr 21, 2018
@boegel boegel requested a review from a team April 21, 2018 20:42
@boegel boegel changed the title fix running --containerize with --extended-dry-run fix running --containerize --container-build-image with --extended-dry-run Apr 21, 2018
@boegel
Copy link
Member Author

boegel commented Apr 21, 2018

@FooBarQuaxx you'll need to sync your branch for #2479 with develop after this gets merged, and resolve the merge conflicts

Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ocaisa ocaisa merged commit 11a73e8 into easybuilders:develop Apr 21, 2018
@boegel boegel deleted the containerize_x branch April 22, 2018 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants