Skip to content

don't blindly overwrite -Dccflags + honour preconfigopts in Perl easyblock #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2023
Merged

don't blindly overwrite -Dccflags + honour preconfigopts in Perl easyblock #3010

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions easybuild/easyblocks/p/perl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def configure_step(self):
configopts = [
self.cfg['configopts'],
'-Dcc="{0}"'.format(os.getenv('CC')),
'-Dccflags="{0}"'.format(os.getenv('CFLAGS')),
'-Dccflags="{0}"'.format(os.getenv('CFLAGS')) if '-Dccflags' not in self.cfg['configopts'] else '',
'-Dinc_version_list=none',
'-Dprefix=%(installdir)s',
# guarantee that scripts are installed in /bin in the installation directory (and not in a guessed path)
Expand Down Expand Up @@ -116,7 +116,7 @@ def configure_step(self):
if os.getenv('COLUMNS', None) == '0':
unset_env_vars(['COLUMNS'])

cmd = './Configure -de %s' % configopts
cmd = '%s ./Configure -de %s' % (self.cfg['preconfigopts'], configopts)
run_cmd(cmd, log_all=True, simple=True)

def test_step(self):
Expand Down