update WRF easyblock to correctly determine WRF* subdirectory for WRF versions >= 4.5.1
#2997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
changed the title
|
@stefan-wolfsheimer Sticking to the name they're using is fine imho. Whatever we do, if they change their minds again, we'll have to update the easyblock accordingly anyway... |
boegel
changed the title
WRF* subdirectory for WRF versions >= 4.5.1
|
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
boegel
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of version 4.5.1 the directory name in tar archive has changed:
version < 4.0 -> WRFV3.x
version 4.4 -> WRF-4.4
version 4.5.1 -> WRFV4.5.1
How should we deal with it?
4.5.1-foss-2023a-dmpar/WRFV4.5.1to4.5.1-foss-2023a-dmpar/WRF-4.5.1when extracting the tar (consistent with 4.4)4.5.1-foss-2023a-dmpar/WRFV4.5.1(as suggested in this PR)