-
Notifications
You must be signed in to change notification settings - Fork 302
let GROMACS runtime logs show EasyBuild was used by setting -DGMX_VERSION_STRING_OF_FORK configuration option #2571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Knowing that EasyBuild has patched the code and organized the build is potentially valuable information for GROMACS users and developers troubleshooting their runs. PLUMED does further patches to GROMACS, so that is expressed directly also.
|
@boegel Thanks for the guidance! |
|
Only recent GROMACS versions support this, but there's no need add complexity here by limiting to those GROMACS versions, as an unused CMake variable merely issues a warning that can be ignored safely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Kicking off some test builds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback, it is better now!
|
Test report by @akesandgren Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Thanks a lot for the contribution @mabraham! |
Knowing that EasyBuild has patched the code and organized the build is potentially valuable information for GROMACS users and developers troubleshooting their runs.
PLUMED does further patches to GROMACS, so that is expressed directly also.