Hardcoded MKL path in easyblocks breaks starting with imkl 2021.x

[SebastianAchilles]

In imkl < 2021 the libs are located in

$EBROOTIMKL/mkl/lib

This changed with imkl >= 2021 as a new directory structure was introduced which includes the version number:

$EBROOTIMKL/mkl/2021.2.0/lib

A handful of EasyBlocks use the following logic where the location of imkl is hardcoded:

imkl_root = get_software_root('imkl')
if imkl_root:
    imkl_include = os.path.join(imkl_root, 'mkl', 'include')

This breaks with imkl >= 2021. Instead these EasyBlocks should use:

imkl_root = get_software_root('imkl')
if imkl_root:
    imkl_include = os.path.join(os.getenv('MKLROOT'), 'mkl', 'include')

Affected EasyBlocks:

• amber.py Add support for imkl 2021.x in Amber easyblock #2527
• berkeleygw.py Add support for imkl 2021.x in BerkeleyGW easyblock #2528
• cp2k.py Add support for imkl 2021.x in CP2K easyblock #2529
• freefem.py Add support for imkl 2021.x in FreeFEM easyblock #2530
• gromacs.py Add support for imkl 2021.x in GROMACS easyblock #2531
• numexpr.py fix easyblock 'numexpr' for Intel MKL 2021 new directory structure #2523 Add support for imkl 2021.x in numexpr easyblock #2532

[boegel]

@SebastianAchilles All PRs merged, so I guess this can be closed?

[SebastianAchilles]

Closing this issues as all PRs have been merged.