Fix ComboBox popup content to allow grouping in Fluent #10878
Merged
+4
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
Kuldeep-MS,
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10878 +/- ##
===================================================
- Coverage 13.48885% 2.98814% -10.50071%
===================================================
Files 3317 3319 +2
Lines 664749 664895 +146
Branches 74643 74675 +32
===================================================
- Hits 89667 19868 -69799
- Misses 572488 644846 +72358
+ Partials 2594 181 -2413
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
harshit7962
approved these changes
May 27, 2025
|
Thank you @h3xds1nz for the fix! |
|
@harshit7962 Thanks :) |
dipeshmsft
added a commit
to dipeshmsft/wpf
that referenced
this pull request
Jun 3, 2025
dipeshmsft
added a commit
that referenced
this pull request
Jun 3, 2025
* Fixed ComboBox style and template * Addressed PR Review comments * Addressed BorderThickness issue * Removed extra variables * Rebased the branch to use the new theme file genenration * Reintroduced ComboBox popup grouping fix #10878
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10629
Description
Replaces
StackPanelasItemsHostwithItemsPresenterto align theComboBoxdropdown menu with rest of the themes and support grouping properly. Noticed this isn't fixed in #10818 either so doing it here.Customer Impact
Without taking this fix, using grouping templates is not feasible.
Regression
Not really, this has been the case since grabbing the template from WpfUi.
Testing
Local build, testing different grouping scenarios, repro in #10629, confirming it works.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow