Skip to content

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Sep 8, 2025

This PR removes support for dotnet.config and switches the runner/platform choice to global.json instead.

dotnet.config was a new configuration file in .NET 10 that we only used for dotnet.test.runner setting. It's available up to RC1 already (RC1 will ship with dotnet.config). This PR aims to remove dotnet.config starting with RC2. This is based on user feedback about dotnet.config

@Youssef1313 Youssef1313 marked this pull request as draft September 8, 2025 14:14
@Youssef1313
Copy link
Member Author

DRAFTING to avoid accidental merge for now.

Copy link
Member

@tkapin tkapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the new logic is tested. It can be done in a separate PR.

Also, please make sure that the PR is properly described.

@Youssef1313 Youssef1313 marked this pull request as ready for review September 10, 2025 17:50
@Youssef1313
Copy link
Member Author

The change is approved.

@Youssef1313 Youssef1313 enabled auto-merge (squash) September 10, 2025 17:50
@Youssef1313 Youssef1313 merged commit a219732 into release/10.0.1xx Sep 10, 2025
27 of 28 checks passed
@Youssef1313 Youssef1313 deleted the dev/ygerges/globaljson branch September 10, 2025 18:27
@KalleOlaviNiemitalo
Copy link
Contributor

This is based on user feedback about dotnet.config

Out of curiosity, where was this user feedback provided?

I searched for dotnet.config in issues, pull requests, and discussions in the dotnet/sdk repository, and in Visual Studio feedback, but did not find objections to it.

@Youssef1313
Copy link
Member Author

@KalleOlaviNiemitalo I'm aware of some internal feedback. @Evangelink Do you know if we also got public user feedback here?

@Evangelink
Copy link
Member

Main source was internal feedback, but we also got some from framework authors and few pings on either blogposts or videos (I can't recall).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants