-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update test command to use global.json #50673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5674a05 to
3a63b10
Compare
src/Cli/Microsoft.TemplateEngine.Cli/PostActionProcessors/AddJsonPropertyPostActionProcessor.cs
Outdated
Show resolved
Hide resolved
|
DRAFTING to avoid accidental merge for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure the new logic is tested. It can be done in a separate PR.
Also, please make sure that the PR is properly described.
src/Cli/Microsoft.TemplateEngine.Cli/PostActionProcessors/AddJsonPropertyPostActionProcessor.cs
Outdated
Show resolved
Hide resolved
|
The change is approved. |
Out of curiosity, where was this user feedback provided? I searched for |
|
@KalleOlaviNiemitalo I'm aware of some internal feedback. @Evangelink Do you know if we also got public user feedback here? |
|
Main source was internal feedback, but we also got some from framework authors and few pings on either blogposts or videos (I can't recall). |
This PR removes support for
dotnet.configand switches the runner/platform choice toglobal.jsoninstead.dotnet.configwas a new configuration file in .NET 10 that we only used fordotnet.test.runnersetting. It's available up to RC1 already (RC1 will ship with dotnet.config). This PR aims to removedotnet.configstarting with RC2. This is based on user feedback aboutdotnet.config