Cleanup dotnet test #50666
Merged
Cleanup dotnet test #50666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure fieldCount is written even if Properties is null or empty.
drognanar
reviewed
Sep 8, 2025
src/Cli/dotnet/Commands/Test/MTP/Terminal/TerminalTestReporterOptions.cs
Show resolved
Hide resolved
src/Cli/dotnet/Commands/Test/MTP/Terminal/TerminalTestReporterOptions.cs
Show resolved
Hide resolved
| { | ||
| LogDiscoveredTests(discoveredTestMessages); | ||
|
|
||
| // TODO: If _handshakeInfo is null, we should error. |
There was a problem hiding this comment.
will this TODO be fixed before this is merged? is there a tracking issue?
would it make sense to throw an InvalidOperationException if _handshakeInfo is null?
There was a problem hiding this comment.
@drognanar A different PR. An umbrella issue for this is #50630
drognanar
approved these changes
Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.