Skip to content

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Aug 27, 2025

Fixes #50147

FYI @baronfel

@Youssef1313 Youssef1313 marked this pull request as ready for review August 27, 2025 06:37
@Copilot Copilot AI review requested due to automatic review settings August 27, 2025 06:37
Copy link
Contributor

This PR is targeting main, which is now for .NET 11-facing work. If you intended to target .NET 10, either retarget this PR to release/10.0.1xx or make sure you backport the change to release/10.0.1xx after merging. See #50394 for more details.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issue #50147 by preventing the use of RuntimeIdentifier (RID) specifications at the solution level when using MTP (Multi-Targeting Platform) dotnet test commands, which is not supported and should produce an error.

  • Adds _MTPBuild target to existing MSBuild checks for solution-level RID usage
  • Renames existing test method to be more specific about testing project-level arch options
  • Adds new test to verify that using arch option on solution-level operations produces the expected error

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
Microsoft.NET.Sdk.Solution.targets Extends existing solution-level checks to include MTP build scenarios
GivenDotnetTestBuildsAndRunsTestsWithDifferentOptions.cs Renames existing test and adds new test for solution-level arch option error handling

@Youssef1313 Youssef1313 changed the base branch from main to release/10.0.1xx August 27, 2025 06:38
@Youssef1313 Youssef1313 force-pushed the dev/ygerges/dotnet-test-arch branch from a080c60 to 47f8752 Compare August 27, 2025 06:40
@Youssef1313 Youssef1313 merged commit 27d10fd into release/10.0.1xx Aug 29, 2025
28 checks passed
@Youssef1313 Youssef1313 deleted the dev/ygerges/dotnet-test-arch branch August 29, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate dotnet test --arch ... behavior on solution

3 participants