Skip to content

Conversation

v-wuzhai
Copy link
Contributor

No description provided.

@Copilot Copilot AI review requested due to automatic review settings May 23, 2025 07:33
@v-wuzhai v-wuzhai requested a review from a team as a code owner May 23, 2025 07:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR temporarily skips the CanFilterAuthor_WithoutName test to unblock the main branch by referencing issue #49123.

  • Adds a Skip attribute with a GitHub issue link to the failing test.
Comments suppressed due to low confidence (1)

test/dotnet-new.IntegrationTests/DotnetNewSearchTests.cs:222

  • [nitpick] Add a TODO comment above this test method indicating when and how to re-enable the skipped test once the related issue is resolved.
[Theory]

}

[Theory]
[Theory(Skip = "https://github.com/dotnet/sdk/issues/49123")]
Copy link

Copilot AI May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a brief skip reason alongside the URL, e.g., Skip = "Skipped due to issue #49123: incorrect author filtering" to clarify why the test is disabled.

Suggested change
[Theory(Skip = "https://github.com/dotnet/sdk/issues/49123")]
[Theory(Skip = "https://github.com/dotnet/sdk/issues/49123: Skipped due to issue #49123: incorrect author filtering")]

Copilot uses AI. Check for mistakes.

@nagilson nagilson merged commit 265d237 into main May 23, 2025
30 checks passed
@nagilson nagilson deleted the dev/Jason/skip-test-unblock-main branch May 23, 2025 18:01
@nagilson
Copy link
Member

/backport to release/10.0.1xx-preview5

Copy link
Contributor

Started backporting to release/10.0.1xx-preview5: https://github.com/dotnet/sdk/actions/runs/15216463685

@v-wuzhai
Copy link
Contributor Author

/backport to release/9.0.3xx

Copy link
Contributor

Started backporting to release/9.0.3xx: https://github.com/dotnet/sdk/actions/runs/15247280066

@v-wuzhai
Copy link
Contributor Author

/backport to release/9.0.1xx

Copy link
Contributor

Started backporting to release/9.0.1xx: https://github.com/dotnet/sdk/actions/runs/15247330548

@v-wuzhai
Copy link
Contributor Author

/backport to release/8.0.4xx

Copy link
Contributor

Started backporting to release/8.0.4xx: https://github.com/dotnet/sdk/actions/runs/15247358553

@v-wuzhai
Copy link
Contributor Author

/backport to release/8.0.3xx

Copy link
Contributor

Started backporting to release/8.0.3xx: https://github.com/dotnet/sdk/actions/runs/15247370301

@v-wuzhai
Copy link
Contributor Author

/backport to release/8.0.1xx

Copy link
Contributor

Started backporting to release/8.0.1xx: https://github.com/dotnet/sdk/actions/runs/15247381522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants