Fix CA2025: Unawaited tasks that use 'IDisposable' instances ... #49040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses CA2025 by refactoring the NuGet download logic into a proper async method (so IDisposable instances are awaited) and modernizes the argument list construction using C# 12 collection expressions.
- Moved the
HttpClientdownload and file stream copy into anasynclocal function and invoked it synchronously. - Replaced manual
List<string>construction forArgumentswith a C# 12 collection expression and the spread operator.
Comment on lines
50
to
58
| DownloadNuGetAsync().ConfigureAwait(false).GetAwaiter().GetResult(); | ||
|
|
||
| async Task DownloadNuGetAsync() | ||
| { | ||
| response.Content.CopyToAsync(fs).ConfigureAwait(false).GetAwaiter().GetResult(); | ||
| using var client = new System.Net.Http.HttpClient(); | ||
| using var response = await client.GetAsync(url).ConfigureAwait(false); | ||
| using var fs = new FileStream(nugetExePath, FileMode.CreateNew); | ||
| await response.Content.CopyToAsync(fs).ConfigureAwait(false); | ||
| } |
There was a problem hiding this comment.
[nitpick] Extracting this local async function into a private helper method could improve readability, reduce nesting, and simplify unit testing.
Copilot uses AI. Check for mistakes.
3 tasks
MiYanni
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building sdk.sln from VS the following error is reported and blocks the build:
CA2025: Unawaited tasks that use 'IDisposable' instances may use those instances long after they have been disposed.