[release/9.0-staging] Don't try to offer a conversion to SG COM when properties are involved #119404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properties aren't supported and the analyzer was crashing on the cast to MethodDeclarationSyntax later due to this.
jkoritzinsky
added
area-System.Runtime.InteropServices
code-analyzer
|
Tagging subscribers to this area: @dotnet/interop-contrib |
jtschuster
approved these changes
Sep 17, 2025
JulieLeeMSFT
added
the
Servicing-consider
|
Reminder that PRs into release/9.0-staging need to be completed by 4pm Redmond time on October 13 to make it into the November servicing release. After that point you'll need to target release/9.0 if you want to make the November release. |
AaronRobinsonMSFT
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #119375 to release/9.0-staging
/cc @jkoritzinsky
Customer Impact
If the user defines an interface with
[ComImport]that defines an event or property, they will receive an AD0001 warning/error in their build. Found internally by the Guardian team.Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Added tests to verify that no diagnostic is reported for interfaces with the offending members. Previously we didn't have tests for this case.
Risk
[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]
Low. This is a build-time analyzer and the added tests validate the scenario.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.