-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Remove DSA from macOS #119182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DSA from macOS #119182
Conversation
...es/Common/tests/System/Security/Cryptography/AlgorithmImplementations/DSA/DSAImportExport.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/tests/DSACreateTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/tests/SignatureDescriptionTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/tests/SignatureDescriptionTests.cs
Show resolved
Hide resolved
...curity.Cryptography/tests/X509Certificates/CertificateCreation/PrivateKeyAssociationTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes Digital Signature Algorithm (DSA) support from macOS platforms in the .NET cryptography libraries. The change affects the native Apple cryptography implementation and updates test files to properly handle the absence of DSA support.
Key changes include:
- Removal of DSA-specific enum values and code from the native Apple cryptography implementation
- Updates to test attributes to use conditional testing based on platform DSA support
- Deletion of DSA SecurityTransforms implementation files
- Updates to platform support detection to exclude Apple platforms from DSA support
Reviewed Changes
Copilot reviewed 49 out of 49 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
src/native/libs/System.Security.Cryptography.Native.Apple/pal_signverify.h |
Removes DSA enum value and updates function documentation |
src/native/libs/System.Security.Cryptography.Native.Apple/pal_signverify.c |
Removes DSA-specific transform functions and conditional logic |
src/native/libs/System.Security.Cryptography.Native.Apple/pal_seckey.h |
Updates documentation to remove DSA references |
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/X509Certificates/X509Pal.macOS.cs |
Removes DSA public key decoding logic |
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/X509Certificates/X509CertificateLoader.macOS.cs |
Removes DSA key handling and import logic |
src/libraries/System.Security.Cryptography/src/System/Security/Cryptography/X509Certificates/AppleCertificatePal.Keys.macOS.cs |
Replaces DSA implementation with PlatformNotSupportedException |
src/libraries/System.Security.Cryptography/src/System.Security.Cryptography.csproj |
Removes DSA SecurityTransforms source files and adds NotSupported implementation |
Multiple test files | Updates test attributes from SkipOnPlatform to ConditionalFact/ConditionalTheory using PlatformSupport.IsDSASupported |
src/libraries/Common/tests/System/Security/Cryptography/PlatformSupport.cs |
Adds IsDSASupported property excluding Apple platforms |
src/libraries/Common/src/System/Security/Cryptography/DSASecurityTransforms.*.cs |
Complete removal of DSA SecurityTransforms implementation files |
src/libraries/System.Security.Cryptography/tests/PKCS1MaskGenerationMethodTest.cs
Show resolved
Hide resolved
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
…o DSASecurityTransforms
src/libraries/System.Security.Cryptography.Pkcs/tests/SignedCms/SignedCmsTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Pkcs/tests/SignedCms/SignerInfoTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography.Xml/tests/Samples/SigningVerifyingX509Cert.cs
Outdated
Show resolved
Hide resolved
Breaking change doc: dotnet/docs#48201 |
This removes DSA (FF-DSA) from macOS.
Closes #71738
Fixes #118107