-
Couldn't load subscription status.
- Fork 5.2k
[release/9.0-staging] Fix analyzer tracking of nullable enums #110331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/9.0-staging] Fix analyzer tracking of nullable enums #110331
Conversation
|
Tagging subscribers to this area: @dotnet/illink |
|
This is surfacing existing test failures, fixing in #110340. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. please get a code review. we will take for consideration in 9.0.x
Backport of #109430 to release/9.0-staging
/cc @sbomer
Customer Impact
Originally fixed in .NET 10 when found while investigating a related issue, and we got a customer report after the .NET 9 release. Customer reported via email when attempting to make an app NativeAOT and trim compatible. Impact is that there are unexpected analyzer warnings in source-generated code.
Simple example of a false positive warning customers could hit:
The actual customer-reported issue showed up in source-generated code not controlled by the customer, in a WinUI app:
for generated code like:
Regression
Testing
Added unit test which validates that the same pattern reported by the customer does not produces a warning.
Risk
Low. Analyzer-only change, doesn't impact runtime. Removes incorrect warnings produced by the trim analyzer.