4.x: Fix 3+ arg Zip not working with immediate sources #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinmars
reviewed
Oct 8, 2018
| public override void OnCompleted() | ||
| { | ||
| Dispose(); | ||
| base.Dispose(true); |
There was a problem hiding this comment.
A small comment why the base (and not the own) method is called could be helpful for future readers.
quinmars
approved these changes
Oct 8, 2018
danielcweber
approved these changes
Oct 9, 2018
|
@onovotny I cherry picked this bugfix for a v4.1.2 release, bumped the version, pushed it to rel/v4.1.2. |
|
Okay, it's rolling out to NuGet now. BTW, for bugfix/patch releases, I think we should make those to the rel/v4.1 branch and keep branches for major/minor updates. I've pushed the changes into the rel/v4.1 branch. |
|
Alright! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with the 3+ argument
Zipoperator not producing anything with an immediateObservable.Returnsource(s).The problem was that the per-source
OnCompletedcalled theDisposemethod which then called the overriddenDispose(bool)method insideZipObservablethat cleared the queue, thus the operator could never make a full row. The fix is to call the originalDispose(bool)which only disposes the upstream but leaves the queue alone.Fixes: #824