Move to .NET SDK 9.0.300 #2208
Merged
Move to .NET SDK 9.0.300 #2208
+1,986
−1,560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBC, but I don't think this is useful to us (since Rx is not intended to be consumed by non-.NET WinRT code) and it's kicking in only because we have types that implement IDisposable. It's possible that this is only happening because of an SDK bug.
This is attempting to generate code for a scenario we don't support (use of Rx types from non-.NET languages via WinRT). It causes a lot of diagnostic messages, and may also be causing unproductive code bloat.
This mostly entails using collection expression syntax. We were already using it in a lot of places, but with the 9.0 SDK we saw a load of extra diagnostics for this in test projects
Turns out the configuration setting is ignored by everything except pack!
…DotNetCoreCli task seems intent on rewriting quotes in ways I don't want.
…l Debug Without this change, running `dotnet build` from the command line fails as it attempts to build the UWP test runner project, something that dotnet build can't actually build.
There were situations in which Scheduling a timed work item in the TaskPoolScheduler would occasionally end up running the work before returning from Schedule. This was not intentional, and occurred due small window in which a Delay task could complete before a continuation was attached to it. (This only seems to have started happening in .NET 9.0.) #2207 Also I realised there were bugs in the relevant tests: they had Asserts inside the work item callbacks, but those assertions would fire on threads not known to the unit test framework, and nothing in the test code attempted to await the work and rethrow back on the test thread. So I restructured these to move all of the assertions back into the main test bodies.
VS decided after a few minutes idle that it had changed its mind about some diagnoser results, so I had to change some more settings.
Rx.NET/Source/facades/System.Reactive.WindowsRuntime/System.Reactive.WindowsRuntime.csproj
Outdated
Show resolved
Hide resolved
Rx.NET/Source/src/System.Reactive.Observable.Aliases/System.Reactive.Observable.Aliases.csproj
Show resolved
Hide resolved
Fix typo in ADR Co-authored-by: Howard van Rooijen <[email protected]>
We had a workaround for xunit/xunit#2703 but this has been fixed, so by upgrading we can remove the workaround. This is good because it turns out the workaround doesn't work if you have a machine with a dev drive user via an alias folder. (Some parts of the build system resolve to the unaliased dev drive path, and so our <Compile Remove> didn't actually match the thing it's meant to be removing!)
HowardvanRooijen
approved these changes
Jun 6, 2025
idg10
added a commit
that referenced
this pull request
Aug 29, 2025
Unit tests now run on net9.0 (and continue to run on net8.0, net472, and UWP) Removed .net6.0 and .net7.0 targets from test runner because those runtimes are out of support Removed dependency on MSBuild.SDK.Extras
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes:
net9.0(and continue to run onnet8.0,net472, and UWP).net6.0and.net7.0targets from test runner because those runtimes are out of supportMSBuild.SDK.ExtrasMinor changes:
Debug (UWP)configuration, because we need to disable building of the UWP Test Runner project in order fordotnet buildto work with its defaultDebugconfiguration