Skip to content

Conversation

@dfederm
Copy link
Contributor

@dfederm dfederm commented Sep 17, 2024

Fixes #10671

Currently the ProjectMetadataElement.Name setter updates the XmlNode for ProjectMetadataElement, but when the metadata is expressed as an attribute it does not update the attribute on the parent node.

This change does the bookeeping for the parent node.

One interesting tidbit is how even when expressed as an attribute, ProjectMetadataElement still uses an (unparented) XmlElementWithLocation to represent it.

@dfederm dfederm force-pushed the fix-metadata-name-setter branch from 685cba3 to 5d01701 Compare September 17, 2024 15:42
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JanKrivanek JanKrivanek merged commit 2935bcd into dotnet:main Oct 1, 2024
10 checks passed
This was referenced Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Setting ProjectMetadataElement.Name has weird behavior

3 participants