[Java.Base] Fix CS0108 Warnings #1008
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: a65d6fb Context: 22d5687 Context: fadbb82 Commit a65d6fb added [warning CS0108][0] to `$(NoWarn)`, as there was no way to fix this warning on `IAnnotatedArrayType`. With commits 22d5687 and fadbb82, it is now possible to fix the CS0108 warning on `IAnnotatedArrayType`, among others. Remove CS0108 from `$(NoWarn)`, and use `Metadata.xml` to fix/avoid the constructs which caused the CS0108 warnings. One CS0108 which *isn't* fixed by [reabstraction][1] of Interface Default Members is for the [`java.io.ByteArrayInputStream.mark`][2] field, which has the same name -- and thus hides -- the [`InputStream.mark()` method][3]. This isn't a problem for Java -- context disambiguates between field access and a method invocation -- but in C# the easier solution is to use Metadata to rename `ByteArrayInputStream.mark` to `ByteArrayInputStream.MarkedPosition`, which fixes the CS0108. [0]: https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/compiler-messages/cs0108 [1]: https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/proposals/csharp-8.0/default-interface-methods#reabstraction [2]: https://developer.android.com/reference/java/io/ByteArrayInputStream#mark [3]: https://developer.android.com/reference/java/io/InputStream#mark(int)
jpobst
approved these changes
Jul 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: a65d6fb
Context: 22d5687
Context: fadbb82
Commit a65d6fb added warning CS0108 to
$(NoWarn), as therewas no way to fix this warning on
IAnnotatedArrayType.With commits 22d5687 and fadbb82, it is now possible to fix the
CS0108 warning on
IAnnotatedArrayType, among others.Remove CS0108 from
$(NoWarn), and useMetadata.xmlto fix/avoidthe constructs which caused the CS0108 warnings.
One CS0108 which isn't fixed by reabstraction of
Interface Default Members is for the
java.io.ByteArrayInputStream.markfield, which has the samename -- and thus hides -- the
InputStream.mark()method.This isn't a problem for Java -- context disambiguates between field
access and a method invocation -- but in C# the easier solution is to
use Metadata to rename
ByteArrayInputStream.marktoByteArrayInputStream.MarkedPosition, which fixes the CS0108.