-
Couldn't load subscription status.
- Fork 3.3k
[9.0] Resolve query logger from QueryContext in shaper generation (#36758) #36778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6758) Instead of closing over the current scoped logger, causing a leak. Closes dotnet#36464 (cherry picked from commit b7996be)
cincuranet
approved these changes
Sep 15, 2025
This was referenced Oct 14, 2025
Open
Bump Microsoft.EntityFrameworkCore from 9.0.8 to 9.0.10
higorbandeira/ExampleCQRSCleanArchitecture#7
Open
This was referenced Oct 27, 2025
Open
Open
mlapaglia
pushed a commit
to mlapaglia/OpenAlprWebhookProcessor
that referenced
this pull request
Oct 28, 2025
[//]: # (dependabot-start)⚠️ **Dependabot is rebasing this PR**⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Updated [AwesomeAssertions](https://github.com/AwesomeAssertions/AwesomeAssertions) from 9.1.0 to 9.2.1. <details> <summary>Release notes</summary> _Sourced from [AwesomeAssertions's releases](https://github.com/AwesomeAssertions/AwesomeAssertions/releases)._ ## 9.2.1 <!-- Release notes generated using configuration in .github/release.yml at main --> ## What's Changed ### Improvements * Use new string diff visualization for StringStartStrategy and StringEndStrategy by @tbui17 in AwesomeAssertions/AwesomeAssertions#225 ### Fixes * Support classes nested inside generic classes by @mat128 in AwesomeAssertions/AwesomeAssertions#307 * Fix broken, unwanted dependency to JetBrains.Annotations by @cbersch in AwesomeAssertions/AwesomeAssertions#310 ### Dependencies * chore(deps): update dependency bogus to 35.6.4 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#285 * chore(deps): update dependency benchmarkdotnet to 0.15.4 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#284 * chore(deps): update dependency meziantou.analyzer to 2.0.221 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#286 * chore(deps): update dependency tunit to 0.61.39 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#287 * chore(deps): update dependency tunit to 0.61.58 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#288 * chore(deps): update dependency verify.xunit to 30.19.1 - autoclosed by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#289 * chore(deps): update dependency meziantou.analyzer to 2.0.224 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#292 * chore(deps): update dependency roslynator.analyzers to 4.14.1 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#293 * chore(deps): update dependency tunit to 0.66.13 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#294 * chore(deps): update dependency verify.xunit to 30.20.1 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#295 * chore(deps): update dependency nunit3testadapter to 5.2.0 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#296 * chore(deps): update mstest monorepo by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#297 * chore(deps): update dependency tunit to 0.70.0 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#301 * chore(deps): update dependency meziantou.analyzer to 2.0.225 - autoclosed by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#300 * chore(deps): update dependency publicapigenerator to 11.5.0 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#302 * chore(deps): update dependency tunit to 0.70.2 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#304 * chore(deps): update dependency verify.xunit to v31 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#305 ### Others * Update docs for 9.2.0 by @cbersch in AwesomeAssertions/AwesomeAssertions#282 * Move string diff improvements to unreleased section by @cbersch in AwesomeAssertions/AwesomeAssertions#299 ## New Contributors * @mat128 made their first contribution in AwesomeAssertions/AwesomeAssertions#307 **Full Changelog**: AwesomeAssertions/AwesomeAssertions@9.2.0...9.2.1 ## 9.2.0 <!-- Release notes generated using configuration in .github/release.yml at main --> > [!CAUTION] > This version is not recommended due to the following issue: AwesomeAssertions/AwesomeAssertions#309 ## What's Changed ### New features * Add collection Contain with occurrence constraint by @cbersch in AwesomeAssertions/AwesomeAssertions#238 ### Improvements * Use consistent newlines in failure messages by @cbersch in AwesomeAssertions/AwesomeAssertions#212 * Improve string comparison visualization by @cbersch in AwesomeAssertions/AwesomeAssertions#215 ### Fixes * fix: string equivalency throwing erroneous whitespace exceptions when using comparer by @tbui17 in AwesomeAssertions/AwesomeAssertions#221 * Fix false positive sonarqube issues by @cbersch in AwesomeAssertions/AwesomeAssertions#268 * Fix documentation tips formatting by @cbersch in AwesomeAssertions/AwesomeAssertions#274 ### Documentation * Update docs for 9.1.0 by @cbersch in AwesomeAssertions/AwesomeAssertions#207 * Remove obsolete question from faq by @cbersch in AwesomeAssertions/AwesomeAssertions#237 ### Dependencies * fix(deps): update dependency cspell to v9.1.5 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#209 * chore(deps): update dependency verify.xunit to 30.5.0 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#216 * fix(deps): update dependency cspell to v9.2.0 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#217 * chore(deps): update dependency meziantou.analyzer to 2.0.208 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#222 * chore(deps): update dependency roslynator.analyzers to 4.14.0 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#223 * chore(deps): update dependency meziantou.analyzer to 2.0.210 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#230 * chore(deps): update mstest monorepo by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#232 * chore(deps): update dependency jetbrains.annotations to v2025 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#224 * chore(deps): update mstest monorepo by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#242 * chore(deps): update dependency meziantou.analyzer to 2.0.212 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#241 * chore(deps): update dependency nunit3testadapter to 5.1.0 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#243 * chore(deps): update dependency verify.xunit to 30.6.1 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#245 * chore(deps): update dependency tunit to 0.55.6 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#244 * chore(deps): update actions/checkout action to v5 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#246 * chore(deps): update mstest monorepo by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#248 * chore(deps): update dependency tunit to 0.56.44 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#249 * chore(deps): update dependency verify.xunit to 30.7.3 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#250 * chore(deps): update actions/download-artifact action to v5 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#251 * chore(deps): update dependency tunit to 0.57.1 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#253 * chore(deps): update dependency meziantou.analyzer to 2.0.215 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#263 * chore(deps): update dependency tunit to 0.57.24 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#264 * fix(deps): update dependency cspell to v9.2.1 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#266 * chore(deps): update dependency verify.xunit to 30.11.0 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#267 * chore(deps): update mstest monorepo by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#265 * chore(deps): update dependency meziantou.analyzer to 2.0.220 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#276 * chore(deps): update dependency benchmarkdotnet to 0.15.3 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#275 * chore(deps): update dependency tunit to 0.61.13 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#278 * chore(deps): update dependency newtonsoft.json to 13.0.4 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#277 * chore(deps): update dependency verify.xunit to 30.18.0 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#279 * chore(deps): update actions/setup-dotnet action to v5 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#280 * chore(deps): update dependency tunit to 0.61.22 by @renovate[bot] in AwesomeAssertions/AwesomeAssertions#281 ### Others ... (truncated) Commits viewable in [compare view](AwesomeAssertions/AwesomeAssertions@9.1.0...9.2.1). </details> Updated [Magick.NET-Q8-AnyCPU](https://github.com/dlemstra/Magick.NET) from 14.8.2 to 14.9.0. <details> <summary>Release notes</summary> _Sourced from [Magick.NET-Q8-AnyCPU's releases](https://github.com/dlemstra/Magick.NET/releases)._ ## 14.9.0 ### What's Changed - Converting Tif file with 2 alpha channels yields scrambled result. #1523 - Embedded base64 image not rendered when converting SVG on Linux RHEL (regression since 14.7.1) #1917 - Allow setting the `StrokeDashArray` of the `DrawingSettings` to `null`. - Moved static properties in `ColorProfile` to a new `ColorProfiles` class and mark them obsolete. ### Related changes in ImageMagick since the last release of Magick.NET: - Fix issue where the size of a line is extended to 70 characters when writing a PBM image (ImageMagick/ImageMagick#8346). - Extra images will be added as meta channels when combining images. - Added support for reading and writing meta channels in a TIFF images with separate planes of data. - Promote photometric tiff tag to required - Added extra check to resolve issue on 32-bit systems (GHSA-9pp9-cfwx-54rm) ### Library updates: - ImageMagick 7.1.2-7 (2025-10-15) - aom 3.13.1 (2025-09-05) - openexr 3.4.0 (2025-09-05) - freetype 2.14.1 (2024-09-11) - gdk-pixbuf 2.44.3 (2025-09-30) - harfbuzz 12.1.0 (2025-10-01) - libjpeg-turbo 3.1.2 (2025-09-03) - openjpeg 2.5.4 (2025-09-20) - libtiff 4.7.1 (2025-09-12) - libxml2 2.15.0 (2025-09-15) **Full Changelog**: dlemstra/Magick.NET@14.8.2...14.9.0 Commits viewable in [compare view](dlemstra/Magick.NET@14.8.2...14.9.0). </details> Updated [Microsoft.AspNetCore.Mvc.Testing](https://github.com/dotnet/aspnetcore) from 9.0.9 to 9.0.10. <details> <summary>Release notes</summary> _Sourced from [Microsoft.AspNetCore.Mvc.Testing's releases](https://github.com/dotnet/aspnetcore/releases)._ ## 9.0.10 [Release](https://github.com/dotnet/core/releases/tag/v9.0.10) ## What's Changed * Update branding to 9.0.10 by @vseanreesermsft in dotnet/aspnetcore#63510 * [9.0] Make duplicate deb/rpm packages so we can sign them with the new PMC key by @jkoritzinsky in dotnet/aspnetcore#63249 * [release/9.0] Extend Unofficial 1ES template in IdentityModel nightly tests job by @github-actions[bot] in dotnet/aspnetcore#63465 * [release/9.0] (deps): Bump src/submodules/googletest from `373af2e` to `eb2d85e` by @dependabot[bot] in dotnet/aspnetcore#63501 * [release/9.0] Quarantine ResponseBody_WriteContentLength_PassedThrough by @wtgodbe in dotnet/aspnetcore#63533 * [release/9.0] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/aspnetcore#63304 * [release/9.0] [OpenAPI] Use invariant culture for TextWriter by @martincostello in dotnet/aspnetcore#62239 * [release/9.0] Update dependencies from dotnet/extensions by @dotnet-maestro[bot] in dotnet/aspnetcore#63303 * Unquarantine `RadioButtonGetsResetAfterSubmittingEnhancedForm` by @ilonatommy in dotnet/aspnetcore#63556 * [release/9.0] Update dependencies from dotnet/extensions by @dotnet-maestro[bot] in dotnet/aspnetcore#63577 * Merging internal commits for release/9.0 by @vseanreesermsft in dotnet/aspnetcore#63604 * [release/9.0] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/aspnetcore#63648 * backport(9.0): Fix runtime architecture detection logic in ANCM. by @DeagleGross in dotnet/aspnetcore#63707 **Full Changelog**: dotnet/aspnetcore@v9.0.9...v9.0.10 Commits viewable in [compare view](dotnet/aspnetcore@v9.0.9...v9.0.10). </details> Updated [Microsoft.AspNetCore.SignalR.Client](https://github.com/dotnet/aspnetcore) from 9.0.9 to 9.0.10. <details> <summary>Release notes</summary> _Sourced from [Microsoft.AspNetCore.SignalR.Client's releases](https://github.com/dotnet/aspnetcore/releases)._ ## 9.0.10 [Release](https://github.com/dotnet/core/releases/tag/v9.0.10) ## What's Changed * Update branding to 9.0.10 by @vseanreesermsft in dotnet/aspnetcore#63510 * [9.0] Make duplicate deb/rpm packages so we can sign them with the new PMC key by @jkoritzinsky in dotnet/aspnetcore#63249 * [release/9.0] Extend Unofficial 1ES template in IdentityModel nightly tests job by @github-actions[bot] in dotnet/aspnetcore#63465 * [release/9.0] (deps): Bump src/submodules/googletest from `373af2e` to `eb2d85e` by @dependabot[bot] in dotnet/aspnetcore#63501 * [release/9.0] Quarantine ResponseBody_WriteContentLength_PassedThrough by @wtgodbe in dotnet/aspnetcore#63533 * [release/9.0] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/aspnetcore#63304 * [release/9.0] [OpenAPI] Use invariant culture for TextWriter by @martincostello in dotnet/aspnetcore#62239 * [release/9.0] Update dependencies from dotnet/extensions by @dotnet-maestro[bot] in dotnet/aspnetcore#63303 * Unquarantine `RadioButtonGetsResetAfterSubmittingEnhancedForm` by @ilonatommy in dotnet/aspnetcore#63556 * [release/9.0] Update dependencies from dotnet/extensions by @dotnet-maestro[bot] in dotnet/aspnetcore#63577 * Merging internal commits for release/9.0 by @vseanreesermsft in dotnet/aspnetcore#63604 * [release/9.0] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/aspnetcore#63648 * backport(9.0): Fix runtime architecture detection logic in ANCM. by @DeagleGross in dotnet/aspnetcore#63707 **Full Changelog**: dotnet/aspnetcore@v9.0.9...v9.0.10 Commits viewable in [compare view](dotnet/aspnetcore@v9.0.9...v9.0.10). </details> Updated [Microsoft.EntityFrameworkCore.InMemory](https://github.com/dotnet/efcore) from 9.0.9 to 9.0.10. <details> <summary>Release notes</summary> _Sourced from [Microsoft.EntityFrameworkCore.InMemory's releases](https://github.com/dotnet/efcore/releases)._ ## 9.0.10 [Release](https://github.com/dotnet/core/releases/tag/v9.0.10) ## What's Changed * [release/8.0-staging] Merge release/8.0 to release/8.0-staging by @cincuranet in dotnet/efcore#36540 * [release/9.0-staging] Merge release/9.0 to release/9.0-staging by @cincuranet in dotnet/efcore#36541 * [release/9.0] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/efcore#36690 * Update branding to 9.0.10 by @vseanreesermsft in dotnet/efcore#36697 * Update branding to 8.0.21 by @vseanreesermsft in dotnet/efcore#36696 * [automated] Merge branch 'release/8.0' => 'release/9.0' by @github-actions[bot] in dotnet/efcore#36699 * Merging internal commits for release/8.0 by @vseanreesermsft in dotnet/efcore#36727 * Merging internal commits for release/9.0 by @vseanreesermsft in dotnet/efcore#36728 * [automated] Merge branch 'release/8.0' => 'release/9.0' by @github-actions[bot] in dotnet/efcore#36734 * [release/9.0] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/efcore#36753 * [release/8.0] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/efcore#36765 * [release/9.0] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/efcore#36782 * [release/8.0] Disable Guardian Dotnet Analyzers by @AndriySvyryd in dotnet/efcore#36776 * [release/9.0] Disable Guardian Dotnet Analyzers by @AndriySvyryd in dotnet/efcore#36777 * [8.0] Resolve query logger from QueryContext in shaper generation (#36758) by @roji in dotnet/efcore#36779 * [9.0] Resolve query logger from QueryContext in shaper generation (#36758) by @roji in dotnet/efcore#36778 * [release/8.0] Merge release/8.0-staging to release/8.0 by @cincuranet in dotnet/efcore#36788 * [release/9.0] Merge release/9.0-staging to release/9.0 by @cincuranet in dotnet/efcore#36789 * [automated] Merge branch 'release/8.0' => 'release/9.0' by @github-actions[bot] in dotnet/efcore#36784 * [release/9.0] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/efcore#36833 * [release/8.0] Remove OSX.13.ARM64 from HelixTargetQueues by @AndriySvyryd in dotnet/efcore#36838 * [automated] Merge branch 'release/8.0' => 'release/9.0' by @github-actions[bot] in dotnet/efcore#36841 * [release/9.0] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/efcore#36852 * [release/8.0] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/efcore#36853 * [release/8.0] Remove OSX.13.Amd64 target from HelixTargetQueues by @AndriySvyryd in dotnet/efcore#36855 * [automated] Merge branch 'release/8.0' => 'release/9.0' by @github-actions[bot] in dotnet/efcore#36860 * [release/9.0] Update dependencies from dotnet/arcade by @dotnet-maestro[bot] in dotnet/efcore#36867 **Full Changelog**: dotnet/efcore@v9.0.9...v9.0.10 Commits viewable in [compare view](dotnet/efcore@v9.0.9...v9.0.10). </details> Updated [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.14.1 to 18.0.0. <details> <summary>Release notes</summary> _Sourced from [Microsoft.NET.Test.Sdk's releases](https://github.com/microsoft/vstest/releases)._ ## 18.0.0 ## What's Changed * Update reporting formatting by @martincostello in microsoft/vstest#15082 * Fix stack trace for Trace.Fail and Debug.Fail by @nohwnd in microsoft/vstest#15103 * Add documentation of environment variables by @Copilot in microsoft/vstest#15095 * IFrameworkHandle.LaunchProcessWithDebuggerAttached allows null for workingDirectory in signature but throws by @Copilot in microsoft/vstest#15091 * Add Dependabot configuration for .NET SDK updates by @JamieMagee in microsoft/vstest#15114 * Handle dotnet_root in testhost version aware way by @nohwnd in microsoft/vstest#15184 * Add magic bytes validation for Mach-O binaries in DotnetHostHelper by @Copilot in microsoft/vstest#15230 * using globbing pattern doesn't work on windows with forward slashes by @Copilot in microsoft/vstest#15088 * Remove tpv0 by @nohwnd in microsoft/vstest#15247 * Cache AssemblyName in ManagedNameHelper by @Youssef1313 in microsoft/vstest#15259 * Add ARM64 support to GetArchitectureForSource methods by @Copilot in microsoft/vstest#15278 ### Internal fixes and updates * Fix formatting in two files by @ViktorHofer in microsoft/vstest#15047 * Build TestPlatform packages in VMR by @ViktorHofer in microsoft/vstest#15055 * Condition property on .NET FX MSBuild by @jaredpar in microsoft/vstest#15054 * Migrate to awesome assertions by @nohwnd in microsoft/vstest#15056 * Revert "Build TestPlatform packages in VMR" by @ViktorHofer in microsoft/vstest#15057 * Update package Category by @ViktorHofer in microsoft/vstest#15058 * Revert "Write props of tests into trx" by @nohwnd in microsoft/vstest#15080 * Error on unsupported tfms (#15072) by @nohwnd in microsoft/vstest#15073 * Use policies from testfx to align by @nohwnd in microsoft/vstest#15085 * Update enable-auto-merge.yml by @nohwnd in microsoft/vstest#15102 * Revert ignoring environment test by @Copilot in microsoft/vstest#15094 * unignore tests by @Copilot in microsoft/vstest#15093 * Update MSTest by @Youssef1313 in microsoft/vstest#15108 * Bump dotnet-sdk from 9.0.106 to 9.0.301 by @dependabot[bot] in microsoft/vstest#15179 * Use Assert.Equals by @nohwnd in microsoft/vstest#15181 * Run VSTest tests with MTP by @Youssef1313 in microsoft/vstest#15079 * Use the standard sdk for architecture switch test by @nohwnd in microsoft/vstest#15188 * Remove CUIT (Coded UI Test) from NuGet packages and test projects by @Copilot in microsoft/vstest#15177 * dump-logs? by @nohwnd in microsoft/vstest#15187 * Moving to version 18 by @nohwnd in microsoft/vstest#15209 * Update fakes version by @drognanar in microsoft/vstest#15227 * Microsoft.Intellitrace.Core should be taken from nuget by @nohwnd in microsoft/vstest#15229 * Remove MSTest.Assert.Extensions by @Youssef1313 in microsoft/vstest#15178 * Sourcebuild fix by @nohwnd in microsoft/vstest#15239 * Set dotnet_root_<arch> only when the architecture of dotnet in the path is the same by @nohwnd in microsoft/vstest#15250 * Remove fakes v1 from FakesUtilities by @drognanar in microsoft/vstest#15251 * Update fakes dependencies by @drognanar in microsoft/vstest#15254 * Do half the work in GetManagedName by @Youssef1313 in microsoft/vstest#15255 * check Vsix only when produced by @nohwnd in microsoft/vstest#15261 * Set dotnet_root_<arch> always by @nohwnd in microsoft/vstest#15266 * Don't hardcode old vswhere version in global.json by @akoeplinger in microsoft/vstest#15267 * Revert dowgrade of fakes by @nohwnd in microsoft/vstest#15263 * Update VSSDK to version with code flow guard by @nohwnd in microsoft/vstest#15279 * Update Fakes to version with code flow guard by @nohwnd in microsoft/vstest#15273 ... (truncated) Commits viewable in [compare view](microsoft/vstest@v17.14.1...v18.0.0). </details> Updated [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter) from 5.1.0 to 5.2.0. <details> <summary>Release notes</summary> _Sourced from [NUnit3TestAdapter's releases](https://github.com/nunit/nunit3-vs-adapter/releases)._ ## 5.2.0 See [release notes](https://docs.nunit.org/articles/vs-test-adapter/AdapterV4-Release-Notes.html) Commits viewable in [compare view](nunit/nunit3-vs-adapter@5.1.0...V5.2.0). </details> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of closing over the current scoped logger, causing a leak.
Closes #36464, backports #36758 to 9.0
Description
When generating the shaper (code which reads back results from the database), the current logic wrongly captures the current query logger (which is a scoped service); this means that whatever logger is in use when the query is first compiled gets referenced from the shaper, and stored in our singleton query cache potentially forever (or until evicted). The logger has references ultimately leading to the EF change tracker and through it, meaning that these user objects are kept alive forever (a form of leak).
Customer impact
With specific usage, arbitrary large user objects may be kept alive forever, and never garbage-collected. In addition, the wrong query logger instance may get used (the one from when the query was first compiled, instead of the current one for the query being executed), which could lead to incorrect logging.
We have performed patch servicing for this kind of bug before (because of the leak potential).
How found
Customer report
Regression
Yes, from EF 7 to EF 8; introduced in #31100.
Testing
This is unfortunately difficult/possible to test automatically, as it's about an unwanted reference in the shaper keeping objects alive. Tested manually to ensure that the shaper no longer contains the reference.
Risk
Low. The change is simple, and we have ample code coverage for the affected codepaths; quirk added.