[rc2] Add a test for default owned collection mapping #36663
Merged
+49
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a test case to verify that Entity Framework Core correctly validates and throws an exception when owned collections are mapped to the same table by default, which is not allowed. The test confirms existing validation behavior for issue #35710.
Key changes:
- Added new test
Owned_type_collections_are_mapped_to_same_tables_by_default()to verify proper validation - Made two test base classes abstract as they should not be instantiated directly
- Removed an unrelated test that was likely moved elsewhere
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| SqlServerModelBuilderTestBase.cs | Added test for default owned collection mapping validation and removed unrelated test |
| PrecompiledSqlPregenerationQueryRelationalTestBase.cs | Changed class from public to abstract |
| PrecompiledQueryRelationalTestBase.cs | Changed class from public to abstract |
roji
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already are correctly throwing in validation for this scenario.
Fixes #35710
@artl93 Test-only change