Rename Relationships query tests to Associations #36643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: roji <[email protected]>
… successful Co-authored-by: roji <[email protected]>
Copilot
AI
changed the title
[WIP] In EFCore.Specifications.Tests, there's a set of query tests under Query/Relationships; these are extended in Relational and Cosmos, and the Relational ones are extended in SQL Server and SQLite. We've decided to rename these tests from being about "Re...
Rename Relationships query tests to Associations
Aug 24, 2025
Copilot finished work on behalf of
roji
August 24, 2025 20:41
|
/cc @artl93 test-only changes |
AndriySvyryd
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames all relationship query tests in
EFCore.Specification.Tests/Query/Relationshipsto use "Associations" terminology instead of "Relationships". This change makes the terminology more appropriate as "relationships" is too specific to relational databases, while "associations" is more general and applies across all database providers including document databases like Cosmos DB.Changes Made
Core Class Renames
RelationshipsProjectionTestBase→AssociationsProjectionTestBaseRelationshipsCollectionTestBase→AssociationsCollectionTestBaseRelationshipsMiscellaneousTestBase→AssociationsMiscellaneousTestBaseRelationshipsSetOperationsTestBase→AssociationsSetOperationsTestBaseRelationshipsStructuralEqualityTestBase→AssociationsStructuralEqualityTestBaseRelationshipsQueryFixtureBase→AssociationsQueryFixtureBaseRelationshipsData→AssociationsDataRelationshipsModel→AssociationsModelDirectory Structure
Query/Relationships/→Query/Associations/Query/Relationships/→Query/Associations/Query/Relationships/directories moved toQuery/Associations/Namespace Updates
Updated all namespaces from
Microsoft.EntityFrameworkCore.Query.RelationshipstoMicrosoft.EntityFrameworkCore.Query.Associations, including all subdirectories:.Navigations.OwnedNavigations.ComplexProperties.ComplexJson.ComplexTableSplitting.OwnedJson.OwnedTableSplittingProvider Coverage
Updated test implementations across all providers:
What Was Preserved
Inheritance relationship tests were intentionally left unchanged as they serve a different purpose:
InheritanceRelationshipsQueryTestBaseTPTRelationshipsQueryTestBase(Table Per Type)TPCRelationshipsQueryTestBase(Table Per Concrete)InheritanceRelationshipsDataImpact
This change improves the clarity of EF Core's test organization by using terminology that better reflects the cross-database nature of these query patterns.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.