Handle complex collections in the model snapshot #36517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances Entity Framework Core's model snapshot generation to properly handle complex properties, including value type complex properties and complex collections. The changes ensure that complex property configurations are correctly serialized and deserialized in migration snapshots.
Key changes:
- Fixed snapshot generation for value type complex properties using
typeof()instead of generic syntax - Added missing extension methods for
ComplexCollectionTypePropertyBuilderto support relational database configurations - Updated test cases to verify proper handling of complex properties in snapshots
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
test/EFCore.Design.Tests/Migrations/Design/CSharpMigrationsGeneratorTest.ModelSnapshot.cs |
Updated test cases to verify complex property snapshot generation, including value type structs and JSON mapping scenarios |
src/EFCore.Relational/Extensions/RelationalComplexCollectionTypePropertyBuilderExtensions.cs |
Added comprehensive extension methods for configuring complex collection properties in relational databases |
src/EFCore.Design/Migrations/Design/CSharpSnapshotGenerator.cs |
Fixed snapshot generation logic to handle complex collections and value types correctly using typeof() syntax |
Comments suppressed due to low confidence (1)
cincuranet
approved these changes
Aug 7, 2025
AndriySvyryd
force-pushed
the
Issue36494
branch
from
a817044 to
bf874ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix value type complex properties in the model snapshot
Fixes #36494
Part of #31237