-
Notifications
You must be signed in to change notification settings - Fork 6.1k
[F#] Add FS0410 compiler message #49100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds documentation for the F# compiler error message FS0410, which occurs when a type with lower accessibility is used in a more accessible context. The documentation includes a code example demonstrating the error and explains the underlying access control issue.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| samples/snippets/fsharp/compiler-messages/fs0410.fsx | Adds example code demonstrating FS0410 error with private type used in public function |
| docs/fsharp/language-reference/compiler-messages/toc.yml | Adds TOC entry for FS0410 documentation |
| docs/fsharp/language-reference/compiler-messages/fs0410.md | Creates complete documentation for FS0410 compiler error message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @64J0
This looks great. I have a few suggestions for you to consider.
Co-authored-by: Bill Wagner <[email protected]>
Co-authored-by: Bill Wagner <[email protected]>
Co-authored-by: Bill Wagner <[email protected]>
Co-authored-by: Bill Wagner <[email protected]>
Co-authored-by: Bill Wagner <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @64J0
This LGTM, and I'll
now.
You should see the changes on the live site in the next day or so on our regular publishing cycle.
Summary
This PR adds the missing documentation for the FS0410 compiler message.
It's defined at the FSComp.txt document.
Related to #48442.
Internal previews