Skip to content

Clarify record type definition with primary constructors #48110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Clarify record type definition with primary constructors #48110

wants to merge 2 commits into from
+3 −1

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Aug 25, 2025 •
edited by github-actions bot
Loading

@gewarren gewarren requested a review from a team as a code owner August 25, 2025 22:09
@dotnetrepoman dotnetrepoman bot added this to the August 2025 milestone Aug 25, 2025
BillWagner
BillWagner approved these changes Aug 26, 2025
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM overall. There's some nuances on primary constructors, records, and public properties that could be misleading for some readers. I had one suggestion. Feel free to reword so it flows in this article.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

+1 more reviewer

@shethaadit shethaadit shethaadit approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
August 2025
Development

Successfully merging this pull request may close these issues.

[UUF] Clarify structured output setup
3 participants
@gewarren @BillWagner @shethaadit