Updated GetAll to work with example code #24114
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the example implementation of CardType GetAll now works as it will search for Properties and not Fields
adegeo
approved these changes
May 13, 2021
Contributor
adegeo
left a comment
adegeo
left a comment
There was a problem hiding this comment.
#23726 broke this code. Does anyone know why they were originally implemented as fields and not properties? That seems deliberate. Otherwise, it seems this PR is good. The sample code though needs to be fixed to match https://github.com/dotnet-architecture/eShopOnContainers/blob/dev/src/Services/Ordering/Ordering.Domain/AggregatesModel/BuyerAggregate/CardType.cs
Member
|
This was fixed in a different way, elsewhere. Closing this, see #24236 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
With the example implementation of CardType GetAll now works as it will search for Properties and not Fields