API Diff between .NET 10.0 Preview 5 and Preview 6

[ericstj]

Repo area owners:

• ASP.NET - @dotnet/aspnet-api-review
• WinForms - @merriemcgaw @JeremyKuhne
• WPF - @pchaurasia14 (no changes)
• Libraries - @artl93 @jeffschwMSFT @jeffhandley @karelz @ericstj @stephentoub @SamMonoRT

[tarekgh]

We may think in improving the tool formatting as I am seeing it is mis-indent some lines especially with const like public const System.Formats.Cbor.CborConformanceMode Canonical = 2; and other patterns like properties has new or required keyword on it.

[OwnageIsMagic]

@tarekgh CborConformanceMode is an enum. Seems like tool is able to handle enums, but only if it is already existed.

[tarekgh]

Thanks @OwnageIsMagic for the catch.

@ericstj It looks like we need to fix this issue in the tool. The enum isn’t new, yet the tool is generating it as a class. It seems the entire System.Formats.Cbor code being generated shouldn't be there at all.

Here is an example:
https://github.com/dotnet/runtime/blob/38192e3cbd5610c9fa3d814506424ad93dfa19b2/src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborConformanceLevel.cs#L14

+ namespace System.Formats.Cbor
+ {
+     public sealed class CborConformanceMode
+     {
+ public const System.Formats.Cbor.CborConformanceMode Canonical = 2;
+         public const System.Formats.Cbor.CborConformanceMode Ctap2Canonical = 3;
+         public const System.Formats.Cbor.CborConformanceMode Lax = 0;
+         public const System.Formats.Cbor.CborConformanceMode Strict = 1;
+         public int value__;
+     }
+ }

[ericstj]

That's a bizarre bug - the enum hasn't been touched for some time.
https://github.com/dotnet/runtime/blame/3eac7ee1b21c1c205a8a13828a4f0883f1e5f56b/src/libraries/System.Formats.Cbor/ref/System.Formats.Cbor.cs#L9-L15

What changed was the System.Formats.Cbor assembly was added to ASP.NET. This sort of bug occurs when the core assembly is not resolvable for key types like System.Enum, object, etc. GenAPI will just guess.

I think I see where the bug is, I'll put up a PR.

[ericstj]

I opened #9988 - thank you for noticing this.