[release/10.0] Enable ControlFlowGuard for ANCM native .dll's #63437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables Control Flow Guard (CFG) for AspNetCore Module native DLLs to fix Binskim security alerts. CFG is a Windows security feature that helps prevent exploitation of memory corruption vulnerabilities.
- Adds the
/guard:cfcompiler option to enable Control Flow Guard - Applied to both common build settings and CustomAction project
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Installers/Windows/AspNetCoreModule-Setup/build/settings/common.props | Adds CFG compiler option to common build settings |
| src/Installers/Windows/AspNetCoreModule-Setup/CustomAction/aspnetcoreCA.vcxproj | Adds CFG compiler option to CustomAction project settings |
src/Installers/Windows/AspNetCoreModule-Setup/CustomAction/aspnetcoreCA.vcxproj
Show resolved
Hide resolved
|
Idk what these dlls are called, but the ANCM native dlls are in https://github.com/dotnet/aspnetcore/tree/main/src/Servers/IIS/AspNetCoreModuleV2 |
wtgodbe
requested review from
BrennanConroy,
JamesNK and
halter73
as code owners
Good catch, added it for a few more shipping assemblies (there are alerts filed for OutOfProcess & aspnetcore.dll) |
BrennanConroy
approved these changes
Aug 26, 2025
joperezr
approved these changes
Aug 26, 2025
ericstj
approved these changes
Aug 26, 2025
wtgodbe
added
the
tell-mode
|
Confirmed that |
wtgodbe
added a commit
that referenced
this pull request
Aug 27, 2025
[release/10.0] Enable ControlFlowGuard for ANCM native .dll's Co-authored-by: William Godbe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Binskim alerts