Skip to content

[main] Update dependencies from dotnet/source-build-reference-packages #56947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 26, 2024
Merged

[main] Update dependencies from dotnet/source-build-reference-packages #56947

merged 5 commits into from
Jul 26, 2024

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jul 23, 2024 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/source-build-reference-packages

  • Subscription: 34ebb389-daeb-4237-045c-08db4c01eb9e
  • Build: 20240724.1
  • Date Produced: July 24, 2024 8:23:40 PM UTC
  • Commit: 26ae006620fb4518276b494efac55dbcd8f80224
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/source-build-refer…
5bf30c0 
…ence-packages build 20240722.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.24365.1 -> To Version 9.0.0-alpha.1.24372.2
@dotnet-maestro dotnet-maestro bot requested review from a team and wtgodbe as code owners July 23, 2024 12:42
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 23, 2024
dotnet-policy-service[bot]
dotnet-policy-service bot approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

dotnet-maestro bot added 2 commits July 24, 2024 12:28
@dotnet-maestro
Update dependencies from https://github.com/dotnet/source-build-refer…
d2bce16 
…ence-packages build 20240723.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.24365.1 -> To Version 9.0.0-alpha.1.24373.1
@dotnet-maestro
Update dependencies from https://github.com/dotnet/source-build-refer…
fa8976a 
…ence-packages build 20240724.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.24365.1 -> To Version 9.0.0-alpha.1.24374.1
@BrennanConroy
Copy link
Member

BrennanConroy commented Jul 25, 2024

@ellahathaway asn1 is failing the prebuilt here. I have no idea what any of this is, but saw you were removing asn1 in source-build.

@ellahathaway
Copy link
Member

ellahathaway commented Jul 25, 2024

@ellahathaway asn1 is failing the prebuilt here. I have no idea what any of this is, but saw you were removing asn1 in source-build.

System.Formats.Asn1.6.0.0 was removed in SBRP due to a CG alert: dotnet/source-build#4518

We added System.Formats.Asn1.6.0.1, so this dependency should be bumped to that version to address the prebuilt.

@BrennanConroy
Copy link
Member

BrennanConroy commented Jul 25, 2024

We don't explicitly bring in asn1 AFAIK. Are we supposed to explicitly bring it in now?

@ellahathaway
Copy link
Member

ellahathaway commented Jul 25, 2024 •
edited
Loading

We don't explicitly bring in asn1 AFAIK. Are we supposed to explicitly bring it in now?

Ah yeah, this is a transitive dependency. The dependency graph is NuGet.Packaging.6.2.4, System.Security.Cryptography.Pkcs.5.0.*, System.Formats.Asn1.6.0.0.

Because this SBRP flow passes in the larger VMR build without any prebuilts, this dependency can be added to the prebuilt baseline. I'll update this PR to include it in the baseline.

@ellahathaway ellahathaway requested a review from a team as a code owner July 25, 2024 20:00
@dotnet-maestro
Update dependencies from https://github.com/dotnet/source-build-refer…
e2b08a3 
…ence-packages build 20240724.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 9.0.0-alpha.1.24365.1 -> To Version 9.0.0-alpha.1.24374.1
@build-analysis build-analysis bot mentioned this pull request Jul 26, 2024
Closed
3 tasks
@BrennanConroy BrennanConroy merged commit 25db949 into main Jul 26, 2024
@BrennanConroy BrennanConroy deleted the darc-main-00ab17cb-b404-4d46-9360-41c6b98a19dc branch July 26, 2024 16:47
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-rc1 milestone Jul 26, 2024
@wtgodbe wtgodbe mentioned this pull request Aug 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotnet-policy-service dotnet-policy-service[bot] dotnet-policy-service[bot] approved these changes

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

Assignees

No one assigned

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼

Projects

None yet

Milestone

9.0-rc1

Development

Successfully merging this pull request may close these issues.

3 participants

@BrennanConroy @ellahathaway