Fix components-e2e pipeline #44402
Merged
Fix components-e2e pipeline #44402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MackinnonBuck
added
the
area-infrastructure
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
TanayParikh
approved these changes
Oct 6, 2022
ghost
added this to the
Member
Author
|
/backport to release/7.0 |
|
Hi @MackinnonBuck. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context. |
Contributor
|
Started backporting to release/7.0: https://github.com/dotnet/aspnetcore/actions/runs/3201143528 |
This was referenced Oct 13, 2022
MackinnonBuck
added a commit
that referenced
this pull request
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix components-e2e pipeline
The cause of the issue appears to be how we were opening/switching tabs to sign in during the auth tests. There seems to be some flakiness in
IWebDriver.WindowHandles(possibly a selenium bug). This PR simplifies our approach and avoids usingWindowHandles.I also updated the ChromeDriver version, since that hasn't been done in a while.
Fixes #44385