Fix compiler and update Odata sample #1127
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commonsensesoftware
requested changes
Nov 15, 2025
Collaborator
commonsensesoftware
left a comment
commonsensesoftware
left a comment
There was a problem hiding this comment.
Most of this looks fine with a couple of minor housekeeping changes and then it can be merged.
| Email = "[email protected]", | ||
| Phone = "555-555-5555", | ||
| }, | ||
| new() { |
Collaborator
There was a problem hiding this comment.
❓ Was there a reason you felt compelled to add yourself? 😆
| // Add services to the container. | ||
|
|
||
| builder.Services.AddControllers().AddOData(); | ||
| builder.Services.AddControllers() |
Collaborator
There was a problem hiding this comment.
Did this auto-wrap? I'd prefer that this be one of the following:
- A single line
.AddControllersand.AddODataalign vertically
I don't have a super strong opinion about which one you choose
| @@ -0,0 +1,22 @@ | |||
| @HostAddress = https://localhost:5001 | |||
Collaborator
There was a problem hiding this comment.
I don't see how this file is necessary at all. The OpenAPI example supplants the need for it. While I'm not completely opposed to the idea, this file just feels one-off and out of sync with the other examples. I'm not convinced this is worth keeping - yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compiler errors and update Odata sample
Summary of the changes (Less than 80 chars)
Description
Updated the OData sample and fixed the compiler error