PublishingActivityProgressReporter fixes

[mitchdenny]

Fixes: #8570

This PR fixes a race condition that existed with the PublishingActivityProgressReporter API. The issue was that when someone used the old API to update the status/create the status of an issue it was possible for another piece of code to mutate the state of the publishing activity.

This in turn resulted in internal logic in the AppHostRpcTarget detecting that a publishing activity was completed and yield returning the activity stream without actually transmitting the completed activity.

This resulted in the CLI interpretting this as a failure state (even though the apphost returned a zero exit code).

The fix was to rework the API for the PublishingActivityProgressReporter so that it is similar to what we do with the ResourceNotificationService. Now we have an API where we create a new status object based on the old one.

Here is an example of the new usage:

// Create activity
var publishingActivity = await activityReporter.CreateActivityAsync(
  "publishing-artifacts",
  $"Executing publisher {executionContext.PublisherName}",
  isPrimary: true,
  stoppingToken).ConfigureAwait(false);

// Update activity status.
await activityReporter.UpdateActivityStatusAsync(
  publishingActivity,
  (status) => status with { IsComplete = true },
  stoppingToken).ConfigureAwait(false);

Here is a video of Kubernetes publisher working where this issue was first noticed:

aspire-activityreporter-fixes.mp4

[Copilot]

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/Aspire.Cli/Commands/PublishCommand.cs:178

• [nitpick] The variable 'lastPublishingActivity' is assigned within the loop but never used elsewhere. Consider removing it if it is redundant, or integrate it in subsequent logic if it was intended to be used.

                (string Id, string StatusText, bool IsComplete, bool IsError)? lastPublishingActivity = null;

[mitchdenny]

/backport to release/9.2

[github-actions]

Started backporting to release/9.2: https://github.com/dotnet/aspire/actions/runs/14298999219