Adding public API test coverage Aspire.Hosting.NodeJs

[Alirexaa]

Contributes to #2649 and #5047

Microsoft Reviewers: Open in CodeFlow

[radical]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Zombach]

Missing check in constructor

https://github.com/dotnet/aspire/blob/main/src/Aspire.Hosting.NodeJs/NodeAppResource.cs

[Alirexaa]

Missing check in constructor

https://github.com/dotnet/aspire/blob/main/src/Aspire.Hosting.NodeJs/NodeAppResource.cs

ExecutableResource has check for that.

[Zombach]

Missing check in constructor
https://github.com/dotnet/aspire/blob/main/src/Aspire.Hosting.NodeJs/NodeAppResource.cs

ExecutableResource has check for that.

Yes, I know, there was just a case message when the name of a parameter differed from the name of the parameter being checked in the ExecutableResource.
And it turns out that if someone makes changes to the code and changes the name, or starts using parameters in the NodeAppResource class, an error will occur.
I'm certainly not sure. But I would cover all public APIs with this check,
when it's not entirely transparent. Not everyone knows that the check for 'null' is found internally in the ExecutableResource.
But this is just my opinion, I don’t know what others will say about this

[sebastienros]

@Alirexaa you missed this one. It has a default value but it doesn't mean we still can't call it with a null value.

[sebastienros]

Also I had to force push to revert the changes in the .sln file.