Skip to content

Conversation

@martincostello
Copy link
Member

@martincostello martincostello commented Jul 2, 2024

- Bump Polly to 8.4.1 to pick up bug fixes.
- Group Polly dependabot updates.
@ghost ghost added the area-codeflow for labeling automated codeflow. intentionally a different color! label Jul 2, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 2, 2024
@danmoseley danmoseley closed this Jul 2, 2024
@danmoseley danmoseley reopened this Jul 2, 2024
@martincostello
Copy link
Member Author

I think the packages need mirroring.

@danmoseley
Copy link
Member

I thought I did.. I'll try again

@danmoseley danmoseley closed this Jul 2, 2024
@danmoseley danmoseley reopened this Jul 2, 2024
@danmoseley danmoseley enabled auto-merge (squash) July 2, 2024 18:43
@danmoseley danmoseley closed this Jul 2, 2024
auto-merge was automatically disabled July 2, 2024 19:04

Pull request was closed

@danmoseley danmoseley reopened this Jul 2, 2024
@danmoseley
Copy link
Member

I had mirrored Polly but not Polly.Extensions.

We really need an the internal mirror process to be easier, it makes me type in every package and version number, each one is a pipeline run unless I just want latest .. maybe @joperezr already has a script...

@danmoseley
Copy link
Member

for this reason, I'm inclined to mostly ignore random updates eg AWS patch versions and then catch up for our releases. whereas this Polly update, it's clear it brings improvements we need.

@danmoseley danmoseley enabled auto-merge (squash) July 2, 2024 19:06
@joperezr
Copy link
Member

joperezr commented Jul 2, 2024

I had mirrored Polly but not Polly.Extensions.

We really need an the internal mirror process to be easier, it makes me type in every package and version number, each one is a pipeline run unless I just want latest .. maybe @joperezr already has a script...

Technically speaking, you can likely get away with a single run most of the time if you keep version as "latest". Given the whole point of these updates is to mirror latest on NuGet, having "latest" on the pipeline means "latest for each package available on NuGet" which is most of the time what you want with these updates. That said, I think it is great feedback, and we should ask @dotnet/dnceng to see if they can allow passing in key-value pairs instead.

@danmoseley
Copy link
Member

Technically speaking, you can likely get away with a single run most of the time if you keep version as "latest". Given the whole point of these updates is to mirror latest on NuGet, having "latest" on the pipeline means "latest for each package available on NuGet" which is most of the time what you want with these updates. That said, I think it is great feedback, and we should ask @dotnet/dnceng to see if they can allow passing in key-value pairs instead.

You're right that latest is 98% what we want.

OK, this seems to work -- paste in the entire list each time:
https://gist.github.com/danmoseley/0c9e188da88639fdf39e19ee02dfc722
image

Choosing "new or non microsoft" is fine as for Microsoft ones that simply repeats work the regular job does hourly, it adds 20 sec per package. that will get what we need 98% of the time, then we go bump the PR jobs.

It would also help if we grouped them together more coarsely, so there were fewer PR's.

@danmoseley
Copy link
Member

cc @radical fyi ^^

@danmoseley
Copy link
Member

Looks like it takes 46 mins to do the whole lot.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-codeflow for labeling automated codeflow. intentionally a different color! community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants