typed-document-node: camelCase exports by default?

[A-Shleifman]

First of all, thank you for this amazing plugin!

By default it generates TypedDocumentNodes in PascalCase. While it makes sense for all generated TypeScript types, it probably should be camelCase for nodes as they are values rather than types. For example, typescript-react-apollo generates functions that start with lowercase letters.

There's a config option namingConvention, but setting it to change-case-all#camelCase changes the case of types as well, which is not what we're looking for.

It also looks like omitOperationSuffix property doesn't work. Ideally, I would like to see the following being generated:

export const getUserQuery = ...;
export const deleteUserMutation = ...;

Is there a config property I'm missing?

[dotansimha]

Hi! This issue is specific to codegen and not to this repo. I'm moving it.

[n1ru4l]

@A-Shleifman Can you send a PR with failing tests for omitOperationSuffix?

[A-Shleifman]

Sorry, @n1ru4l and @dotansimha for not getting back to this for so long. omitOperationSuffix is no longer relevant as useQuery(GetUserDocument) works much better. The other problem is still relevant. I think typed-document-node should generate Documents in camelCase instead of PascalCase as they are variables, not types.

For example:

type GetUserResult = ResultOf<typeof GetUserDocument>;

this looks like we're trying to get typeof Type. I think it should be getUserDocument.

If I try to configure it myself:

overwrite: true
schema: "./schema.gql"
documents: "queries.gql"
generates:
  graphql.tsx:
    plugins:
      - typescript
      - typescript-operations
      - typed-document-node:
          namingConvention: change-case-all#camelCase

Then the generated variable contains incorrect camelCase types, which should stay PascalCase:

export const getUserDocument = {...} as unknown as DocumentNode<getUserQuery, getUserQueryVariables>;

Here's an example with TypeScript complaining in graphql.tsx

[zingerj]

Somewhat related: is it possible to generate TDNs like GetUserQuery instead of GetUserDocument? I couldn't find a config option for that. Thanks!

[6XGate]

It seems there should probably be a new option for namingConvention, called variableNames maybe, to limit its affect to const/var/let exports.

[aradalvand]

Disappointing to see this option still doesn't exist.