Handle transformed assets URL #397
Conversation
webpack_loader/utils.py
Outdated
|
|
||
| return '{0}{1}'.format(public_path, asset_name) | ||
|
|
||
| def get_asset(asset_name, config='DEFAULT'): |
There was a problem hiding this comment.
Please add a docstring similar to the one from get_static, but clarify why this is different.
webpack_loader/loaders.py
Outdated
| asset = next((x for x in assets if x.get("sourceFilename") == name), None) | ||
| if not asset: | ||
| asset = next((x for x in assets if x["name"] == name), None) | ||
| return asset |
There was a problem hiding this comment.
I think this should read like this:
def get_asset_by_source_filename(self, name):
files = self.get_assets()["assets"]
return next((x for x in files if x.get("sourceFilename") == name), None)
fjsj
left a comment
fjsj
left a comment
There was a problem hiding this comment.
Overall LGTM, but please check suggestions. Thanks for the contribution!
batistadasilva
force-pushed
the
webpack-asset
branch
from
7d52a83 to
889c5b4
Compare
|
@fjsj Thanks for the review! Let me know if all changes fit the requirements |
Adding the following template tag
```
{% webpack_asset 'path/to/original/file' %}
```
Fixes django-webpack#343
Depends on django-webpack/webpack-bundle-tracker#125
batistadasilva
force-pushed
the
webpack-asset
branch
from
889c5b4 to
65dddf2
Compare
| "license": "MIT", | ||
| "devDependencies": { | ||
| "webpack": "^5.91.0", | ||
| "webpack-bundle-tracker": "github:hostnfly/webpack-bundle-tracker#assets-source-filenames", |
|
Released at 3.1.0, thanks again @batistadasilva |
2 participants
Adding the following template tag
Fixes #343
Depends on django-webpack/webpack-bundle-tracker#125