Add skip_common_chunks functionality #297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
script tag issue #289. Uses context to store a list of all loaded tags by default and skips them if the option is set for that invocation of render_bundle
Modified jinja2ext to handle context; Added tests for takes_context and skip_common_chunks
Contributor
Author
|
bumperino |
Contributor
Contributor
Author
|
Yes it does. It is the same functionality but extended. |
joaopslins
reviewed
Sep 13, 2021
joaopslins
reviewed
Sep 13, 2021
Contributor
joaopslins
left a comment
joaopslins
left a comment
There was a problem hiding this comment.
Just pushed a commit with some legibility improvements, and a point for @fjsj to check, otherwise LGTM.
karolyi
commented
Sep 13, 2021
Contributor
Author
|
bump? |
Contributor
Author
|
awesome \o/ |
Member
|
We will make the release early next week, on Monday. |
Member
|
Release made: 1.4.0 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #296, I've added tests to work with Jinja and cleaned up the test suite to remove python3.5 and update to
Jinja2>3since python3.5 has reached EOL.Django<2.2is also non-LTS.