Appending extensions in the url files #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks but I think it would be better to add support to the template tags so they add a suffix to the files like {% render_bundle 'main' 'css' suffix='.gz' %} |
Collaborator
Contributor
Author
|
@owais updated pull request, the suffix now is added in the template tag. |
owais
approved these changes
Dec 13, 2017
webpack_loader/utils.py
Outdated
| tags.append(( | ||
| '<link type="text/css" href="{0}" rel="stylesheet" {1}/>' | ||
| ).format(chunk['url'], attrs)) | ||
| ).format(''.join([chunk['url'], suffix]), attrs)) |
Collaborator
There was a problem hiding this comment.
Why not href="{0}{1}" {2}".format(url, suffix, attrs)?
|
Please consider to merge it or make an .gzip implementation. |
Collaborator
|
Can someone confirm if this is still a viable solution and still works with the latest master before we merge it? |
Member
|
@rvlb could you please check this one? |
# Conflicts: # README.md # webpack_loader/loader.py # webpack_loader/utils.py
# Conflicts: # webpack_loader/templatetags/webpack_loader.py # webpack_loader/utils.py
Contributor
|
FYI this was just included in the 1.3.0 version |
fjsj
added a commit
that referenced
this pull request
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to allow to import gzip files, this pull request adds a configuration section to load the gzip files.