Skip to content

Conversation

@renph
Copy link
Contributor

@renph renph commented Nov 30, 2023

Description

add translation for Simplified Chinese (zh_Hans)

Related Issue

Motivation and Context

Adding translation for Simplified Chinese (zh_Hans), so that more people could use this package.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have run the pre-commit run command to format and lint.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have added my name and/or github handle to AUTHORS.rst
  • I have added my change to CHANGES.rst
  • All new and existing tests passed.

@renph
Copy link
Contributor Author

renph commented Nov 30, 2023

@com4 @jezdez Please review my changes if you got a chance

thesayfulla
thesayfulla previously approved these changes Dec 18, 2023
@codecov
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (29108a5) 96.87% compared to head (3a46e3a) 96.87%.
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1281   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files          23       23           
  Lines        1278     1278           
  Branches      211      211           
=======================================
  Hits         1238     1238           
  Misses         21       21           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ddabble ddabble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! 😊

@ddabble ddabble merged commit f48b53d into django-commons:master Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants