Add temporary asgiref requirement
#1261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1209 added an implicit dependency on
asgiref>=3.6, as the imported functioniscoroutinefunction()was introduced inasgiref3.6.0 (seeasgiref's changelog), but a lower version is the minimum requirement of Django 4.1 and earlier (see e.g. Django 4.1.11'ssetup.cfg).This means that users who happen to install
django-simple-historytogether with Django 4.1 or lower, might implicitly also install a lower version ofasgirefthan what's actually required to run our code.The easiest solution to this seems to be adding a requirement for
asgiref>=3.6, which can be removed when our minimum required Django version is 4.2 or higher.Related Issue
Closes #1255.
Motivation and Context
See the discussion of the issue linked above.
How Has This Been Tested?
Through GitHub actions.
Screenshots (if appropriate):
Types of changes
asgirefas is installed with the Django version they're usingChecklist:
pre-commit runcommand to format and lint.AUTHORS.rstCHANGES.rst