Skip to content

chore: Clean up get_extra_menu_items methods #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

chore: Clean up get_extra_menu_items methods #50

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f700363
chore: Clean up get_extra_menu_items methods
mrbazzan Oct 21, 2025
909318d
Merge branch 'master' into plugin_test
fsbraun Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 16 additions & 41 deletions djangocms_transfer/cms_plugins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,21 +33,12 @@ def get_plugin_urls(self):
]
return urlpatterns

def get_extra_global_plugin_menu_items(self, request, plugin):
# django-cms 3.4 compatibility
return self.get_extra_plugin_menu_items(request, plugin)

@classmethod
def get_extra_plugin_menu_items(cls, request, plugin):
if plugin.plugin_type == cls.__name__:
return

data = urlencode(
{
"language": get_language_from_request(request),
"plugin": plugin.pk,
}
)
@staticmethod
def _get_extra_menu_items(query_params, request):
data = urlencode({
"language": get_language_from_request(request),
**query_params
})
return [
PluginMenuItem(
_("Export plugins"),
Expand All @@ -69,34 +60,18 @@ def get_extra_plugin_menu_items(cls, request, plugin):
),
]

@classmethod
def get_extra_plugin_menu_items(cls, request, plugin):
if plugin.plugin_type == cls.__name__:
return
Comment on lines +63 to +66
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Returning None may be inconsistent with expected return type.

If a list is expected, return an empty list rather than None to maintain consistency and prevent issues for callers.

Suggested change
@classmethod
def get_extra_plugin_menu_items(cls, request, plugin):
if plugin.plugin_type == cls.__name__:
return
@classmethod
def get_extra_plugin_menu_items(cls, request, plugin):
if plugin.plugin_type == cls.__name__:
return []


data = {"plugin": plugin.pk}
return cls._get_extra_menu_items(data, request)

@classmethod
def get_extra_placeholder_menu_items(cls, request, placeholder): # noqa
data = urlencode(
{
"language": get_language_from_request(request),
"placeholder": placeholder.pk,
}
)
return [
PluginMenuItem(
_("Export plugins"),
admin_reverse("cms_export_plugins") + "?" + data,
data={},
action="none",
attributes={
"icon": "export",
},
),
PluginMenuItem(
_("Import plugins"),
admin_reverse("cms_import_plugins") + "?" + data,
data={},
action="modal",
attributes={
"icon": "import",
},
),
]
data = {"placeholder": placeholder.pk}
return cls._get_extra_menu_items(data, request)

@classmethod
def import_plugins_view(cls, request):
Expand Down