Skip to content
This repository was archived by the owner on Mar 26, 2025. It is now read-only.

Conversation

@jrief
Copy link
Collaborator

@jrief jrief commented Mar 24, 2021

Prepare for version 4.0.1

djangocms-picture>=2.1.0
djangocms-link>=2.2.1
django-polymorphic>=2.0.3
django-treebeard<4.5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrief, are you sure it's needed? the latest treebeard version 4.5.1 seems to work fine in my projects

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well yes, for testing legacy releases.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good point. Could we add a comment about it to the line?

For me one of the hardest parts of upgrading a python project is figuring out which of the 100 requirements were frozen accentually, for an outdated reason, or because unfreezing them is going to break the page number 583 :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A side note on that... If you've not come across pip-tools then it makes upgrading packages really simple by managing all the compatibility for you.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I've been using pip-tools and poetry for years now. The issue is a bit subtle though: a developer can see that somebody 3 years ago added a package that isn't functional anymore and breaks the server at the moment. Is that package needed now? Why was it added? Does he need to spend his workday forking its git or testing hundreds of pages after its deletion?

@codecov-io
Copy link

Codecov Report

Merging #555 (54830ca) into master (7d578cd) will increase coverage by 6.02%.
The diff coverage is 100.00%.

❗ Current head 54830ca differs from pull request most recent head 4ac6b29. Consider uploading reports for the commit 4ac6b29 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #555      +/-   ##
==========================================
+ Coverage   66.66%   72.69%   +6.02%     
==========================================
  Files          14       19       +5     
  Lines         390      813     +423     
  Branches       41       89      +48     
==========================================
+ Hits          260      591     +331     
- Misses        117      198      +81     
- Partials       13       24      +11     
Impacted Files Coverage Δ
djangocms_text_ckeditor/__init__.py 100.00% <100.00%> (ø)
djangocms_text_ckeditor/settings.py 89.47% <0.00%> (ø)
djangocms_text_ckeditor/forms.py 100.00% <0.00%> (ø)
djangocms_text_ckeditor/cms_plugins.py 70.80% <0.00%> (ø)
djangocms_text_ckeditor/models.py 84.61% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d578cd...4ac6b29. Read the comment docs.

@marksweb
Copy link
Member

marksweb commented Apr 2, 2021

I've refactored the requirements in #559 but I think having tree beard in each is OK.

Once we switch to GH actions, they'll handle each task that tox is setup to run in development. So the requirement file(s) will be used directly by the actions.

@stale
Copy link

stale bot commented Jul 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 28, 2022
@stale
Copy link

stale bot commented Aug 30, 2022

This will now be closed due to inactivity, but feel free to reopen it.

@stale stale bot closed this Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants