- 
                Notifications
    
You must be signed in to change notification settings  - Fork 186
 
Release 4.0.1 #555
Release 4.0.1 #555
Conversation
        
          
                tests/requirements.txt
              
                Outdated
          
        
      | djangocms-picture>=2.1.0 | ||
| djangocms-link>=2.2.1 | ||
| django-polymorphic>=2.0.3 | ||
| django-treebeard<4.5 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jrief, are you sure it's needed? the latest treebeard version 4.5.1 seems to work fine in my projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well yes, for testing legacy releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good point. Could we add a comment about it to the line?
For me one of the hardest parts of upgrading a python project is figuring out which of the 100 requirements were frozen accentually, for an outdated reason, or because unfreezing them is going to break the page number 583 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A side note on that... If you've not come across pip-tools then it makes upgrading packages really simple by managing all the compatibility for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I've been using pip-tools and poetry for years now. The issue is a bit subtle though: a developer can see that somebody 3 years ago added a package that isn't functional anymore and breaks the server at the moment. Is that package needed now? Why was it added? Does he need to spend his workday forking its git or testing hundreds of pages after its deletion?
          Codecov Report
 
 @@            Coverage Diff             @@
##           master     #555      +/-   ##
==========================================
+ Coverage   66.66%   72.69%   +6.02%     
==========================================
  Files          14       19       +5     
  Lines         390      813     +423     
  Branches       41       89      +48     
==========================================
+ Hits          260      591     +331     
- Misses        117      198      +81     
- Partials       13       24      +11     
 Continue to review full report at Codecov. 
  | 
    
| 
           I've refactored the requirements in #559 but I think having tree beard in each is OK. Once we switch to GH actions, they'll handle each task that tox is setup to run in development. So the requirement file(s) will be used directly by the actions.  | 
    
| 
           This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.  | 
    
| 
           This will now be closed due to inactivity, but feel free to reopen it.  | 
    
Prepare for version 4.0.1