-
Couldn't load subscription status.
- Fork 66
chore: Add tests for django CMS 5.0 #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideAdds support for django CMS 5.0+ in testing by updating CI workflows, packaging metadata, admin comments, and adapting existing tests. Class diagram for updated admin compatibility commentclassDiagram
class PageContent {
+admin_manager
+filter(language)
# Updated: Admin comment now indicates compatibility with django CMS 5.0+
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #244 +/- ##
==========================================
+ Coverage 95.72% 96.01% +0.29%
==========================================
Files 28 28
Lines 678 678
Branches 88 88
==========================================
+ Hits 649 651 +2
+ Misses 13 11 -2
Partials 16 16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @fsbraun - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `pyproject.toml:58` </location>
<code_context>
[tool.setuptools.dynamic]
version = { attr = "djangocms_link.__version__" }
+[tool.setuptools.package-data]
+djangocms_link = [ "static/", "templates/", "locale/", "LICENSE", "README.rst" ]
+
</code_context>
<issue_to_address>
Use recursive globs for nested resource files
Use recursive globs (e.g., "static/**/*", "templates/**/*", "locale/**/*") to ensure all files in subdirectories are included.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
[tool.setuptools.package-data]
djangocms_link = [ "static/", "templates/", "locale/", "LICENSE", "README.rst" ]
=======
[tool.setuptools.package-data]
djangocms_link = [ "static/**/*", "templates/**/*", "locale/**/*", "LICENSE", "README.rst" ]
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Description
Add Django CMS 5 tests
Related resources
Checklist
masterSlack to find a “pr review buddy” who is going to review my pull request.
Summary by Sourcery
Add compatibility and testing updates for django CMS 5.0 by expanding the CI matrix, including package data in the build, updating admin comments, and adjusting tests to use the new admin content API.
Enhancements:
Build:
CI:
Tests:
get_admin_content("en").titleandstr(self.page)in assertions